Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown should be consistent on all clients #5149

Closed
zeratax opened this issue Oct 2, 2017 · 5 comments
Closed

markdown should be consistent on all clients #5149

zeratax opened this issue Oct 2, 2017 · 5 comments
Labels

Comments

@zeratax
Copy link

zeratax commented Oct 2, 2017

Description

as mentioned in https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15069853502593297uCUAW:matrix.org

On android strike through is done like this:
~~strike through~~
but on riot-web:
<del>strike through</del>

Same goes for underline

even riot-web itself isn't consistent currently: #3482

Version information

  • Platform: web and desktop

For the web app:

  • Browser: Firefox
  • OS: Windows, Arch Linux
  • URL: riot.im/app

For the desktop app:

  • OS: Windows, Arch Linux
  • Version: 0.12.4
@t3chguy
Copy link
Member

t3chguy commented Oct 3, 2017

It's a known issue android is not using commonmark as it should.

@lampholder
Copy link
Member

Consistency is certainly important; we're tracking the android issue here: element-hq/riot-android#779

I'm going to close this as a duplicate in favour of the android issue and #3482

@zeratax
Copy link
Author

zeratax commented Oct 4, 2017

Furthermore isn't using html tags for strike through and underline, but for everything else markdown still inconsistent?

People new to riot coming from other messengers in my experience expect strike to work.

@Hi-Angel
Copy link

Hi-Angel commented Oct 5, 2019

Consistency is certainly important; we're tracking the android issue here: vector-im/riot-android#779

I'm going to close this as a duplicate in favour of the android issue and #3482

I might be misreading something, but it sounds like the problem is with riot-web and not the android one. The OP says:

On android strike through is done like this:
~~strike through~~
but on riot-web:
<del>strike through</del>

If you look into github markdown cheatsheet, you'll see that android got it correctly. The problem instead is with riot-web.

@t3chguy
Copy link
Member

t3chguy commented Oct 5, 2019

Riot is using commonmark not github flavoured markdown, riot-android has an open issue to switch to commonmark so it is actually the one which is wrong as commonmark does not support that syntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants