Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot does not properly linkify URLs with custom protocol fields #5094

Open
NotAFile opened this issue Sep 20, 2017 · 2 comments
Open

Riot does not properly linkify URLs with custom protocol fields #5094

NotAFile opened this issue Sep 20, 2017 · 2 comments
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@NotAFile
Copy link
Contributor

Description

When viewing links, of the form protocol://whatever, Riot does not properly highlight the full link

Steps to reproduce

  • Send message with a link with a custom protocol, e.g. aos://151723184:32876:0.75
  • Notice that the aos: does not get linkified, only the //151723184:32876:0.75

Riot should linkify the whole link

image

Version information

  • Platform: web

For the web app:

  • Browser: Chromium, Firefox nightly
  • OS: Debian
  • URL: riot.im/app
@pafcu
Copy link
Contributor

pafcu commented Sep 25, 2017

This is actually an issue with the Linkify library. You might consider reporting it upstream.

@NotAFile NotAFile mentioned this issue Sep 26, 2017
Closed
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P3 labels Oct 24, 2017
@t3chguy t3chguy mentioned this issue Dec 10, 2018
Closed
@NotAFile
Copy link
Contributor Author

Upstream has closed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pafcu @lampholder @NotAFile