Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme: you can't see the quote mark in the dark theme, so for unrenderable URL previews it looks like a oddly-large gap. #3393

Closed
ara4n opened this issue Mar 9, 2017 · 3 comments
Labels
P2 S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 9, 2017

surely they should take up zero height if they don't load

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users ui/ux labels Mar 9, 2017
@lampholder
Copy link
Member

Have you got a screenshot/good example? URLs that don't resolve to real domains/pages don't seem to be taking up any height for me on develop or stable.

@ara4n
Copy link
Member Author

ara4n commented Mar 9, 2017

...........actually this isn't a regression, it's always been like this. but on the dark theme you can't see the quote mark so it looks like entirely whitespace.

screen shot 2017-03-09 at 14 49 49

@lampholder lampholder changed the title link previews that don't load are ugly chunks of whitespace Dark theme: you can't see the quote mark in the dark theme, so for unrenderable URL previews it looks like a oddly-large gap. Mar 24, 2017
@lampholder
Copy link
Member

Two/three possible fixes:

  • change the styling on the dark-theme quote (easy)
  • render a 'this URL can't be previewed' note rather than an empty quote (also easy, slightly more time-consuming)
  • in the case of the specific example, make the URL preview thing able to preview JSON (marginally less easy, again more time-consuming, actually quite useful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants