Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme on dark tint makes buttons look greyed out #3328

Closed
kegsay opened this issue Feb 27, 2017 · 4 comments
Closed

Dark theme on dark tint makes buttons look greyed out #3328

kegsay opened this issue Feb 27, 2017 · 4 comments
Labels
A-Theming P2 S-Tolerable Low/no impact on users

Comments

@kegsay
Copy link
Contributor

kegsay commented Feb 27, 2017

dark-tint
dark-tint2

@ara4n
Copy link
Member

ara4n commented Feb 28, 2017

the bug here is that if you set the colourscheme to make the buttons grey... the buttons are grey? ;D I guess the only mitigation here would be to colour the button text white if you choose the grey colourscheme.

@tessgadwa
Copy link

I think it is a very limiting in general to be using the same set of buttons across light and dark themes; particularly challenging for individuals who are colorblind. I would recommend making two complete sets of SVG icons, one each for light and dark themes. Happy to assist in graphics production, if others feel there is a need. :)

@kegsay
Copy link
Contributor Author

kegsay commented Feb 28, 2017

if you set the colourscheme to make the buttons grey... the buttons are grey?

$insert_50_shades_of_grey_joke

colour the button text white if you choose the grey colourscheme.

Yup, this is what I was gunning for.

@pafcu
Copy link
Contributor

pafcu commented Dec 15, 2017

@kegsay Gray is no longer suggested for tinting. Does this solve the issue?

@uhoreg uhoreg closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Theming P2 S-Tolerable Low/no impact on users
Projects
None yet
Development

No branches or pull requests

5 participants