Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing notif avatars with white background looks a bit weird #3035

Open
uhoreg opened this issue Jan 23, 2017 · 2 comments
Open

typing notif avatars with white background looks a bit weird #3035

uhoreg opened this issue Jan 23, 2017 · 2 comments
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design X-Needs-Product More input needed from the Product team

Comments

@uhoreg
Copy link
Member

uhoreg commented Jan 23, 2017

As shown below:
image
It looks like trilobite17's face is missing, rather than just being covered up, since arx's avatar has a white background which blends into the background. Perhaps setting the border colour around the avatar to be different from the background colour will help. Or maybe some fancy shadow effect?

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jan 25, 2017

Or maybe some fancy shadow effect?

Interesting idea, might be worth considering. But that particular avatar does look as if it's trying to blend in to the background deliberately.

@ara4n
Copy link
Member

ara4n commented Feb 18, 2017

honestly this is such an edge case (hah, see what i did there?) i don't think it's worth trying to second-guess the background colour or the border colour. One could conceivably say "if the background of the image is white or transparent, then we should use an inverted border on it", but this then sets a precedent for putting weird borders on avatars in general. I suggest we ignore it unless it really starts to be a pain in the ass.

@ara4n ara4n added T-Defect S-Tolerable Low/no impact on users P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches labels Feb 18, 2017
@kittykat kittykat added O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design X-Needs-Product More input needed from the Product team and removed P4 [OBSOLETE LABEL] Interesting — Not yet scheduled, will accept patches labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

5 participants