Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element shows multiple reactions from the same user #25872

Closed
timokoesters opened this issue Jul 29, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11340
Closed

Element shows multiple reactions from the same user #25872

timokoesters opened this issue Jul 29, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11340
Assignees
@t3chguy
Labels
T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@timokoesters
Copy link

Steps to reproduce

Join a room with duplicate reactions (for example received over federation from a homeserver with less checks)

Ask me and I'll invite you into an example room.

Outcome

image

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@timokoesters timokoesters mentioned this issue Jul 29, 2023
Open
@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

image

Synapse also seems to aggregate it similarly. I don't see anything in the CS part of the spec about deduplicating m.reaction/m.annotation on (sender;key)

@timokoesters
Copy link
Author

Did you see this?:
image

@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

Nope missed that, good point.

@t3chguy t3chguy added the Z-Spec-Compliance An area where Element doesn't correctly implement the spec label Jul 31, 2023
@t3chguy t3chguy self-assigned this Jul 31, 2023
@t3chguy t3chguy mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

De-duplicate reactions by sender to account for faulty/malicious servers matrix-org/matrix-react-sdk
2 participants
@t3chguy @timokoesters