Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GYU – Quick settings: Implement the "(default)" label #24523

Open
Tracked by #24511
Johennes opened this issue Feb 14, 2023 · 0 comments
Open
Tracked by #24511

GYU – Quick settings: Implement the "(default)" label #24523

Johennes opened this issue Feb 14, 2023 · 0 comments
Assignees
@justjanne
Labels
A-Notifications A-Room-List T-Enhancement Team: App Z-GetYourUpdates

Comments

@Johennes
Copy link
Contributor

Johennes commented Feb 14, 2023 •
edited by daniellekirkwood
Loading

Designs: https://www.figma.com/file/M15i7l4PSPY1B5M7Zhu80H/Notifications?node-id=9040-138522&t=tDtJy79BQirt5h81-0

How it looks today How it looks in the new designs
Screenshot 2023-03-20 at 12 54 07 Screenshot 2023-03-20 at 12 53 46

Acceptance criteria

  • The option in the per-room tool-tip notification menu that matches the global notification setting has a suffix `... (Default)
  • If for any reason we can't map a 'Default' (maybe users change their settings on a different client) then we drop this label - this shouldn't apply in too many cases

Blocks: #24524
@Johennes Johennes mentioned this issue Feb 14, 2023
Open
@Johennes Johennes changed the title Implement the "(default)" label GUY – Quick settings: Implement the "(default)" label Feb 14, 2023
@Johennes Johennes mentioned this issue Feb 14, 2023
Open
@Johennes Johennes changed the title GUY – Quick settings: Implement the "(default)" label GYU – Quick settings: Implement the "(default)" label Feb 14, 2023
@Johennes Johennes mentioned this issue Mar 20, 2023
Closed
@justjanne justjanne self-assigned this Mar 23, 2023
@justjanne justjanne mentioned this issue Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justjanne justjanne

Labels
A-Notifications A-Room-List T-Enhancement Team: App Z-GetYourUpdates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GYU: Implement "default" label for notification quick settings matrix-org/matrix-react-sdk
3 participants
@MadLittleMods @Johennes @justjanne