Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread created without any threaded message #22389

Closed
babolivier opened this issue May 30, 2022 · 4 comments
Closed

Thread created without any threaded message #22389

babolivier opened this issue May 30, 2022 · 4 comments
Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@babolivier
Copy link
Contributor

Steps to reproduce

  1. Send a message

Someone also responded in a thread to a reply I sent after the wrongly threaded message, not sure if that's what caused Element to get confused.

Outcome

What did you expect?

No thread created

What happened instead?

Thread created:

2022-05-30_10-01

The preview is generated from my message

In the thread tab:

2022-05-30_10-01_1

Operating system

Arch Linux

Browser information

100.0

URL for webapp

develop.element.io

Application version

Element version: 70a2474-react-15c2fb6b71b1-js-a4a50a4a5c36, olm version: 3.2.8

Homeserver

element.io

Will you send logs?

Yes
@uhoreg uhoreg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels May 30, 2022
@uhoreg
Copy link
Member

uhoreg commented May 30, 2022

Someone also responded in a thread to a reply I sent after the wrongly threaded message, not sure if that's what caused Element to get confused.

I don't understand this. Can you explain more?

@uhoreg uhoreg added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 30, 2022
@babolivier
Copy link
Contributor Author

babolivier commented May 30, 2022 •
edited
Loading

I don't understand this. Can you explain more?

  1. I send message 1
  2. I send message 2, which is a reply to a message sent before message 1
  3. Someone sends a message in a thread created by message 2

I'm not at all familiar with the thread code so I don't know if that's a red herring or not, but the bug happened around the same time 3 happened so I thought I'd mention it.

@uhoreg uhoreg removed the X-Needs-Info This issue is blocked awaiting information from the reporter label May 30, 2022
@uhoreg
Copy link
Member

uhoreg commented May 30, 2022

Thanks

@germain-gg
Copy link
Contributor

I believe this would have been fixed with the refactor that occurred in matrix-org/matrix-react-sdk#9356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @uhoreg @babolivier