Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Don't send read receipts" lab no longer clears notification badge on the room #22154

Closed
BurnyBoi opened this issue May 11, 2022 · 5 comments
Closed
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@BurnyBoi
Copy link

BurnyBoi commented May 11, 2022

Steps to reproduce

  1. Receive a notification while on the room
  2. Despite hovering the mouse over the window while it is focused and sending a message in the room, the notification badge on the room list no longer clears
  3. I move to another room, select it again, and it still doesn't clear
  4. I go to Labs, disable "Don't send read receipts" lab, then go to the room again, and the badge clears
  5. Re-enable the lab
  6. Repeat process and the problem happens again

Outcome

What did you expect?

Notification badge should clear either when you're currently in the room and the Element window is focused, OR you're not in the room and then go to select it

What happened instead?

Badge never clears when "Don't send read receipts" lab is on:
image

Note: This only started happening when upgrading from 1.10.11 to 1.10.12

Operating system

Arch Linux

Browser information

Firefox 100

URL for webapp

Internal instance

Application version

Element version: 1.10.12-16-g479d4bf64-dirty Olm version: 3.2.8

Homeserver

Private instance

Will you send logs?

No

@BurnyBoi
Copy link
Author

I'm noticing I can get them to eventually clear while the lab is on, but it's very delayed and inconsistent.

@robintown
Copy link
Member

What version of Synapse are you running? The MSC has changed, so you'll need to run at least Synapse 1.59.0rc1 to get the latest server-side support.

@SimonBrandner
Copy link
Contributor

What version of Synapse are you running? The MSC has changed, so you'll need to run at least Synapse 1.59.0rc1 to get the latest server-side support.

Yep, the MSC has changed a lot:

matrix-org/synapse#12168
matrix-org/matrix-js-sdk#2221
matrix-org/matrix-react-sdk#7993

Once all of your software is up to date, it should work again

@robintown robintown added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 11, 2022
@BurnyBoi
Copy link
Author

Oh, I am out of date then for sure. I'm currently on the arch repo version though and it's been flagged out of date for a while with no progress since 1.57.0

@t3chguy
Copy link
Member

t3chguy commented May 11, 2022

matrix-org/synapse#12168 is not even released yet, closing as running incompatible software for the labs option chosen

@t3chguy t3chguy closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

No branches or pull requests

4 participants