Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DuckDuckGo command blocked via CORS #18681

Closed
chayleaf opened this issue Aug 21, 2021 · 3 comments
Closed

DuckDuckGo command blocked via CORS #18681

chayleaf opened this issue Aug 21, 2021 · 3 comments
Labels
A-Autocomplete O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@chayleaf
Copy link

Steps to reproduce

  1. Try using the /ddg command

What happened?

DuckDuckGo API requests blocked.

From browser: Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://api.duckduckgo.com/?q=<query>format=json&no_redirect=1&no_html=1&t=vector. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

From desktop app: Access to fetch at 'https://api.duckduckgo.com/?q=<query>&format=json&no_redirect=1&no_html=1&t=vector' from origin 'vector://vector' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

What did you expect?

DuckDuckGo command working

Operating system

No response

Browser information

No response

URL for webapp

No response

Have you submitted a rageshake?

No
@SimonBrandner SimonBrandner added A-Autocomplete O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Aug 22, 2021
@Palid
Copy link
Contributor

Palid commented Aug 25, 2021

What's even worse, we're getting below message when trying to use /ddg command.
CleanShot 2021-08-25 at 17 16 15@2x

@Palid Palid added O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 25, 2021
@Palid
Copy link
Contributor

Palid commented Aug 25, 2021

Seems like we need to improve the modal text, as /ddg is indeed not a command and it's supposed to autocomplete the things you type into your input box.

Let's revisit this in a week, so we can properly close this one and reopen an enhancement for the modal window being shown when you actually do try using /dgg command (some better header/reminder text or examples would be very useful, as I got caught into it myself).

@Palid
Copy link
Contributor

Palid commented Aug 26, 2021

Closing in favor of #18778

@Palid Palid closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Autocomplete O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Palid @chayleaf @SimonBrandner