Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message actions only exposed on mouse hover #11082

Closed
MarcoZehe opened this issue Oct 8, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3587 or matrix-org/matrix-react-sdk#3709
Assignees

Comments

@MarcoZehe
Copy link

Description

When reading through messages with a screen reader, the message actions to reply to a message etc., aren't visible unless you hover over the message with the mouse. Since screen reader users don't use the mouse to read, and the mouse can be placed anywhere random on the screen, but screen readers do update the DOM focused state of elements that are focusable, the message actions should be shown once a screen reader user enters a particular message.

Steps to reproduce

In Firefox, with the NVDA screen reader:

  • Enter a channel.
  • Use the arrow keys and NVDA's virtual reading cursor to traverse through the messages. Watch as the screen tracks where you're reading.

Expected result: Message actions should become visible for the message the user is currently reading.

Actual: Either no message actions appear, or they only appear for the message the mouse happens to sit on, if any, and changes as the screen scrolls.

Logs being sent: yes/no

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 70 beta, or 71 Nightly.
  • OS: Windows.
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented Oct 8, 2019

I discovered this myself yesterday and have it on my to do as part of General a11y improvements

@t3chguy
Copy link
Member

t3chguy commented Nov 13, 2019

This got regressed

@t3chguy t3chguy reopened this Nov 13, 2019
@MarcoZehe
Copy link
Author

This got regressed

For book keeping, parts of the fix for this were reverted in matrix-org/matrix-react-sdk#3591, and resulted in filing of #11316, as a possible way forward. Right now, screen readers get a toolbar that hides again from virtual cursor once focus moves into it. Not usable unless routing the mouse to the particular message, simulating a hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment