From 03b389763e63ba0f114ebd30a65c570fd19a812e Mon Sep 17 00:00:00 2001
From: Oliver Gupte <olivergupte@gmail.com>
Date: Thu, 21 Jan 2021 15:51:00 -0500
Subject: [PATCH 1/2] [APM] Renames significant terms feature to "Correlations"
 (#88974)

---
 x-pack/plugins/apm/common/ui_settings_keys.ts          |  2 +-
 .../app/Correlations/LatencyCorrelations.tsx           |  2 +-
 .../apm/public/components/app/Correlations/index.tsx   | 10 +++++-----
 x-pack/plugins/apm/server/ui_settings.ts               |  9 ++++-----
 4 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/x-pack/plugins/apm/common/ui_settings_keys.ts b/x-pack/plugins/apm/common/ui_settings_keys.ts
index ffc2a2ef21fe90..38922fa445a471 100644
--- a/x-pack/plugins/apm/common/ui_settings_keys.ts
+++ b/x-pack/plugins/apm/common/ui_settings_keys.ts
@@ -4,5 +4,5 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-export const enableSignificantTerms = 'apm:enableSignificantTerms';
+export const enableCorrelations = 'apm:enableCorrelations';
 export const enableServiceOverview = 'apm:enableServiceOverview';
diff --git a/x-pack/plugins/apm/public/components/app/Correlations/LatencyCorrelations.tsx b/x-pack/plugins/apm/public/components/app/Correlations/LatencyCorrelations.tsx
index b2d88c4c3849b9..438303110fbc46 100644
--- a/x-pack/plugins/apm/public/components/app/Correlations/LatencyCorrelations.tsx
+++ b/x-pack/plugins/apm/public/components/app/Correlations/LatencyCorrelations.tsx
@@ -128,7 +128,7 @@ export function LatencyCorrelations() {
                 <EuiFormRow
                   fullWidth={true}
                   label="Field"
-                  helpText="Fields to analyse for significant terms"
+                  helpText="Fields to analyse for correlations"
                 >
                   <EuiComboBox
                     fullWidth={true}
diff --git a/x-pack/plugins/apm/public/components/app/Correlations/index.tsx b/x-pack/plugins/apm/public/components/app/Correlations/index.tsx
index fada90039aecff..e01d1028f4868d 100644
--- a/x-pack/plugins/apm/public/components/app/Correlations/index.tsx
+++ b/x-pack/plugins/apm/public/components/app/Correlations/index.tsx
@@ -20,7 +20,7 @@ import {
 import { useHistory } from 'react-router-dom';
 import { EuiSpacer } from '@elastic/eui';
 import { isActivePlatinumLicense } from '../../../../common/license_check';
-import { enableSignificantTerms } from '../../../../common/ui_settings_keys';
+import { enableCorrelations } from '../../../../common/ui_settings_keys';
 import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context';
 import { LatencyCorrelations } from './LatencyCorrelations';
 import { ErrorCorrelations } from './ErrorCorrelations';
@@ -35,7 +35,7 @@ export function Correlations() {
   const history = useHistory();
   const [isFlyoutVisible, setIsFlyoutVisible] = useState(false);
   if (
-    !uiSettings.get(enableSignificantTerms) ||
+    !uiSettings.get(enableCorrelations) ||
     !isActivePlatinumLicense(license)
   ) {
     return null;
@@ -48,7 +48,7 @@ export function Correlations() {
           setIsFlyoutVisible(true);
         }}
       >
-        View significant terms
+        View correlations
       </EuiButton>
 
       <EuiSpacer size="s" />
@@ -62,7 +62,7 @@ export function Correlations() {
           >
             <EuiFlyoutHeader hasBorder aria-labelledby="correlations-flyout">
               <EuiTitle>
-                <h2 id="correlations-flyout">Significant terms</h2>
+                <h2 id="correlations-flyout">Correlations</h2>
               </EuiTitle>
             </EuiFlyoutHeader>
             <EuiFlyoutBody>
@@ -88,7 +88,7 @@ export function Correlations() {
                 iconType="alert"
               >
                 <p>
-                  Significant terms is an experimental feature and in active
+                  Correlations is an experimental feature and in active
                   development. Bugs and surprises are to be expected but let us
                   know your feedback so we can improve it.
                 </p>
diff --git a/x-pack/plugins/apm/server/ui_settings.ts b/x-pack/plugins/apm/server/ui_settings.ts
index c86fb636b5a1a6..5c9c96699e803b 100644
--- a/x-pack/plugins/apm/server/ui_settings.ts
+++ b/x-pack/plugins/apm/server/ui_settings.ts
@@ -8,7 +8,7 @@ import { schema } from '@kbn/config-schema';
 import { i18n } from '@kbn/i18n';
 import { UiSettingsParams } from '../../../../src/core/types';
 import {
-  enableSignificantTerms,
+  enableCorrelations,
   enableServiceOverview,
 } from '../common/ui_settings_keys';
 
@@ -16,17 +16,16 @@ import {
  * uiSettings definitions for APM.
  */
 export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
-  [enableSignificantTerms]: {
+  [enableCorrelations]: {
     category: ['observability'],
     name: i18n.translate('xpack.apm.enableCorrelationsExperimentName', {
-      defaultMessage: 'APM Significant terms (Platinum required)',
+      defaultMessage: 'APM Correlations (Platinum required)',
     }),
     value: false,
     description: i18n.translate(
       'xpack.apm.enableCorrelationsExperimentDescription',
       {
-        defaultMessage:
-          'Enable the experimental Significant terms feature in APM',
+        defaultMessage: 'Enable the experimental Correlations feature in APM',
       }
     ),
     schema: schema.boolean(),

From dc05d131cd4306a49f8a7c045efcabd7e2bf5651 Mon Sep 17 00:00:00 2001
From: Oliver Gupte <olivergupte@gmail.com>
Date: Thu, 21 Jan 2021 16:56:40 -0500
Subject: [PATCH 2/2] fix capitalizations

---
 x-pack/plugins/apm/server/ui_settings.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/apm/server/ui_settings.ts b/x-pack/plugins/apm/server/ui_settings.ts
index 5c9c96699e803b..e9bb747280fc7c 100644
--- a/x-pack/plugins/apm/server/ui_settings.ts
+++ b/x-pack/plugins/apm/server/ui_settings.ts
@@ -19,13 +19,13 @@ export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
   [enableCorrelations]: {
     category: ['observability'],
     name: i18n.translate('xpack.apm.enableCorrelationsExperimentName', {
-      defaultMessage: 'APM Correlations (Platinum required)',
+      defaultMessage: 'APM correlations (Platinum required)',
     }),
     value: false,
     description: i18n.translate(
       'xpack.apm.enableCorrelationsExperimentDescription',
       {
-        defaultMessage: 'Enable the experimental Correlations feature in APM',
+        defaultMessage: 'Enable the experimental correlations feature in APM',
       }
     ),
     schema: schema.boolean(),