Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana should use proper exit signal when stops due to a configuration error #96376

Closed
mshustov opened this issue Apr 7, 2021 · 1 comment · Fixed by #96502
Closed

Kibana should use proper exit signal when stops due to a configuration error #96376

mshustov opened this issue Apr 7, 2021 · 1 comment · Fixed by #96502
Assignees
Labels
enhancement New value added to drive a business result Feature:Configuration Settings in kibana.yml Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Apr 7, 2021

@pmuellr pointed out that Cloud doesn't implement such complex validation rules for the configuration as Kibana does.
It might turn out that when a user applies changes on Cloud, a value can be accepted in Cloud UI, but Kibana will fail to start due to a validation error.

When Kibana crashes with a configuration error, it returns either the default error code or 64 when the config file contains unknown values. Thus, Cloud cannot detect a configuration problem with the Kibana server so that it will unsuccessfully try to start the server over and over again.

To help Cloud to detect the configuration problem, Kibana should return the proper exit code to signal that action required before the next attempt. Elasticsearch uses 78 error code for configuration problem https://github.com/elastic/elasticsearch/blob/b32cbc1baa4dbf859cbde91bc7ce5c42929ffadb/libs/cli/src/main/java/org/elasticsearch/cli/ExitCodes.java#L39

Likely, we cannot change the 64 exit code for unknown config values until v8.0 for compatibility reasons, but we can start with returning the 78 exit code when Kibana fails config validation.

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 Feature:Configuration Settings in kibana.yml v7.13.0 labels Apr 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@mshustov mshustov added enhancement New value added to drive a business result and removed v7.13.0 v8.0.0 labels Apr 7, 2021
@pgayvallet pgayvallet self-assigned this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Configuration Settings in kibana.yml Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants