Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve api docs #93940

Closed
flash1293 opened this issue Mar 8, 2021 · 4 comments
Closed

[Lens] Improve api docs #93940

flash1293 opened this issue Mar 8, 2021 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Right now the Lens API docs are not very comfortable to use and should be cleaned up:

  • Do not export internal things (e.g. TopValuesResult or LensServerPlugin)
  • Add explanatory documentation to all exported types
  • For each of the internal services (datasource, various visualization types), create a public_types file and move all exported types there. Re-export from the top level
@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

The goal of this is to provide good documentation of the Lens public API for use by solutions and end users, so I assume that we will also want to expose a few more types publicly like IndexPatternLayer- as this is not currently exposed?

The main use cases I am imagining for users who will read the API docs:

  • Solution teams who are embedding Lens
  • Administrators who want to automate dashboards and need to understand the saved object format

@flash1293
Copy link
Contributor Author

@wylieconlon All of these types should be exposed - see here

IndexPatternLayer specifically isn't exposed, but only because it's not part of the embeddable input - it's PersistedIndexPatternLayer.

Totally agree about the use cases you listed - these are the people we are targeting.

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Feb 15, 2023
@stratoula
Copy link
Contributor

Closing in favor of #152553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants