Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Encourage user to use smaller data set if searches take too long #84908

Closed
flash1293 opened this issue Dec 3, 2020 · 6 comments
Closed
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Dec 3, 2020

On dashboards, Lens already supports the upcoming "Send to background". Within the Lens editor, this doesn't make much sense because it's based on interactivity. If the user wants to edit a visualization tied to slow data sources, they should try to decrease the size of the data set (e.g. just use the last 30mins of data instead of last 2 years) for editing, then when back on dashboard they can send the long running search to background.

If requests are very slow in Lens, we should advise the user to use a smaller data set here and use background sessions when back on the dashboard.

Context

Part of #83640

On dashboards, Lens already supports the upcoming "Send to background". This should also work within the Lens editor. To do so, the "searchSessionId" has to be kept around and passed to the expression to allow the data layer to pick up a search running in the background.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Dec 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@Dosant
Copy link
Contributor

Dosant commented Dec 3, 2020

For reference:
Integration would involve:

  • Creating a URL generator for lens, so data service could build Lens URLs to restore session
  • Using session service to start a new session
  • Passing sessionId through the search infrastructure

Similar integration on a dashboard:

@Dosant
Copy link
Contributor

Dosant commented Dec 7, 2020

Enabling full experience blocked by unability to restore a session without relying on state in the URL

@flash1293
Copy link
Contributor Author

@timductive Just did a follow-up discussion on this with @timroes and @elastic-jb and we agreed this is not terribly high in priority because it's not matching the main user flow for the "Send to background" feature. We will revisit this in 7.13 planning, by then we will have a better idea of how this feature will work in practice and can decide about priority.

@lizozom
Copy link
Contributor

lizozom commented Feb 25, 2021

@flash1293 I think we've had a couple discussions (with you and @timroes as well), deciding that actually "Sending to background" (saving a search session) is not a realistic use case for Lens editor (or visualize editor). We should instead encourage users to edit with a smaller data set.

I think this can be closed and if the need rises at some point, we can discuss this then.

@flash1293 flash1293 changed the title [Lens] Send to background in Lens editor [Lens] Encourage user to use smaller data set if searches take too long Feb 25, 2021
@flash1293
Copy link
Contributor Author

Good point @lizozom, I edited the description. I still think there's something to do here for the current feature set.

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jun 6, 2023
@timductive timductive closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants