[Saved Object Tagging] Post-MVP Improvement

[pgayvallet]

Related to #74571

This issue is here to track and discuss about the possible improvements for the initial SOT implementation done in #79096 that could be done for 7.11

Usage analytics

• Add usage collector for tagging usages - Usage Analytics on Saved Object Tags #81847

Tags management section

• Bulk actions

Was initially planned for the MVP but got blocked by elastic/eui#4095 not being yet integrated into Kibana. Will be unblocked by #81499.

EDIT: #81499 has been merged, task is unblocked.

From the tag management section, the user should be able to select tags on the table to perform batch operations on them

Batch actions would be:

• Export tags and underlying objects

Do we want to check for SO management permission for that one? Else the user may not have read permission to all objects, and would only be exporting a subset of the objects using the tag. Or maybe this is fine

• Delete tags

User need the write permission on the feature for this action

• Assign tag

See #81970

Saved Objects management section

• Hide Tags from saved object management section #147786

To be exportable, tags were required to be visible by SO management, therefor being displayed in the SO management section as other exportable objects. Ideally, they would be exportable while being invisible in SOM.

Requires #82027

Navigational search integration

• add tag to search results

See #81846

Apps integration

Common

• Listing tables: be able to filter by tag by clicking on a tag in the table #147787

See #79096 (comment)

We might want to allow users to click on a tag from the dashboard (or vis, or other) listing table to set the current query/filter to filter by this tag.

We might need some functional rules for that (does clicking on a second tag replaces the current one, or does it add it for example)

Dashboard

• Tags on Add Panel fly-out Tags on Add Panel fly-out #82183

Initial discussion: #79096 (review). Requires to adapt the SavedObjectFinder component to add the tags filter to it.

cc @alexfrancoeur @ryankeairns @MichaelMarcialis #79096 is just too big to follow all the improvements. GH is just dying with the 200+ comments... Created this 'meta' issue for that. Please feel free to add what I forgot or just comment with the requested feature and I will add it to the list.

[elasticmachine]

Pinging @elastic/kibana-core-ui (Team:Core UI)

[alexfrancoeur]

@pgayvallet can I add this one into the mix? #81847

[pgayvallet]

Added to the list

[alexfrancoeur]

Thank you and great work getting tags merged! If I had to prioritize these post-mvp improvements, it'd look something like this:

1. Bulk actions on tags (Add bulk assign to saved object tagging #81970)
   • @ryankeairns @MichaelMarcialis @pgayvallet @myasonik we should touch base on what the ideal experience is, and what's feasible for 7.11
2. Usage analytics (Usage Analytics on Saved Object Tags #81847)
3. Add panel flyout support (Tags on Add Panel fly-out #82183)
4. Navigational search support (pending discussion outcome Integrate tags to navigational search results #81846)
5. Hidden from SO management (SavedObjects should support importing/exporting even if they're hidden from the API #82027)
6. Apps integration (SavedObjects tagging MVP #79096 (comment))

[ryankeairns]

Regarding 1. - Michael will be doing some mockup updates, and I'll set up a meeting for us to catch up next week when Michail is back.

[pgayvallet]

Regarding bulk actions:

I think the mockups are only required for the 'bulk assign' action (even if that's probably the most important one). I can still start a draft PR to add the bulk action menu that already have mockups, and the batch delete action.

EDIT: moved the second section to #81970 to avoid polluting this meta issue.

[ryankeairns]

Related enhancement for deleting tags: #83292

[ryankeairns]

It was noted in a recent product design demo that we could avoid the modal-on-modal design if we used the 'native' EUI combo box functionality and just auto-generated a color. Something to consider for a future enhancement.

Provided component behavior

Current modal-on-modal implementation

[pgayvallet]

It was noted in a recent product design demo that we could avoid the modal-on-modal design if we used the 'native' EUI combo box functionality and just auto-generated a color

Yea, we discussed about it when we decided to open the modal for creation. The main issue with the inline approach is the validation, and displaying the potential error message in a user-friendly way (e.g when the name contains invalid chars and/or is too long). We'll need to solve that if we eventually want to change the on the fly creation workflow.

[MichaelMarcialis]

It was noted in a recent product design demo that we could avoid the modal-on-modal design if we used the 'native' EUI combo box functionality and just auto-generated a color. Something to consider for a future enhancement.

Hey, @ryankeairns. Thanks for adding this note. I had a couple of notes and questions regarding this issue.

The modal-on-modal effect that is currently in the 7.11 MVP is not part of the intended design. The designs instead propose changing the saving interfaces of the analytics apps from a modal to a flyout (in order to avoid this exact scenario). This wasn't implemented in 7.11, as @pgayvallet indicated that such a change will likely need to be made by each app's engineering team. While it can be argued that a modal over a flyout is still the same experience (because the flyout itself is also what I would consider a modal experience), it still looks less odd and follows a pattern used elsewhere in Kibana.

That said, if we don't feel the above flyout change alone will be sufficient, I wonder if it would be worth it to perform some user testing before we remove the create tag modal entirely when adding a new tag inline (and instead automatically apply a color and save the new tag). While we had some early discussion about whether to present the user with this modal or bypass it entirely, I ultimately chose the modal route because of the following concerns:

• Will all users be comfortable navigating into stack management in order to update their tag colors and descriptions?
• If we were to remove the modal, at what point in the process does the new tag get created? If after hitting enter or clicking on the create button in the dropdown, I worry that a lot of accidentally created tags might get created inadvertently.

[ryankeairns]

Sounds good. Let's see what feedback rolls in before making any changes. If nothing else, it is helpful that we've captured all this context for future considerations in this area.

There may be a third option to consider here as well - how could the existing EUI combo box component be enhanced to handle cases like this where validation and confirmation are necessities.

[afharo]

I noticed there are 3 remaining items to do. I created one issue for each one of those, and I'll close this one. Feel free to reopen if we want to keep this issue as their meta issue.