Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Allow user to change y axis settings separately for each axis #74836

Closed
flash1293 opened this issue Aug 12, 2020 · 12 comments · Fixed by #76373
Closed

[Lens] Allow user to change y axis settings separately for each axis #74836

flash1293 opened this issue Aug 12, 2020 · 12 comments · Fixed by #76373
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Aug 12, 2020

Currently it's possible in Lens xy chart to configure some properties of the y axis (hide/show complete axis, tick labels, grid lines as well as overwriting the axis title).

In some cases a chart can have a left and a right y axis. In this case these settings are always applied to both axes in the same way.

The user should be able to control the behavior of the left and the right axis separately.

Suggestion

One way to expose this to the user is to have separate form rows in the settings popover for left y axis and right y axis. If we can be sure there is just a single y axis (e.g. if there is just a single metric or if multiple metrics are specifically mapped to the same axis), we can either disable or hide the form rows for the other Y axis.

Otherwise (e.g. if there are two "auto" mapped metrics or one metric mapped to the left axis and one metric mapped to the right one), we show both rows.

cc @cchaos @stratoula

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

I made a quick implementation of how the right y-axis title will work with the above suggestion:
Lens-Elastic (1)
So if there is no right axis, the setting doesn't appear, it appears only if it is applicable.

The same way could work for gridlines and tick labels but I assume that we should change the UI in X-Axis --> Gridlines, Ticklabels, Left Y-Axis --> Gridlines, Ticklabels and Right Y-Axis --> Gridlines, Ticklabels.

What do you think @cchaos?

@flash1293
Copy link
Contributor Author

As discussed offline, when doing this we should move out the individual axis settings into separate popovers:
Screenshot 2020-08-20 at 17 13 41
Screenshot 2020-08-20 at 17 13 58
Screenshot 2020-08-20 at 17 14 02

@cchaos
Copy link
Contributor

cchaos commented Aug 20, 2020

Those screenshots are slightly out of date. Once this gets underway the best place to find the latest version is in this prototype.

@flash1293
Copy link
Contributor Author

Thanks @cchaos - could you update this issue once the design is ready to give feedback / start implementation?

@stratoula
Copy link
Contributor

It looks great @cchaos!

@cchaos
Copy link
Contributor

cchaos commented Aug 21, 2020

It's ready for feedback now. You can comment directly on the prototype in Figma, or make screenshots and paste comments here.

@stratoula
Copy link
Contributor

stratoula commented Aug 31, 2020

@cchaos as far as I can see also pie charts have global settings but are quite different from the XY axes ones.

Screenshot 2020-08-31 at 2 22 17 PM

Are we going to also change them too? Or this applies only for XY-Axis ?

Moreover, I can't find some of the icons on the prototype. Are they new?

@stratoula stratoula self-assigned this Aug 31, 2020
@cchaos
Copy link
Contributor

cchaos commented Aug 31, 2020

Yes, those would need to be broken apart to fit the new toolbar paradigm. I've started a google doc that breaks down the different global chart settings per chart type so help us organize this.

@stratoula
Copy link
Contributor

Thank you @cchaos, it helps a lot. What about the icons? I can't find them, can you also help me with them?

@cchaos
Copy link
Contributor

cchaos commented Sep 1, 2020

Yes, they don't exist yet. I'm still designing them and they may need to be fed through EUI first. I'd just throw some placeholder icons in there for now. I will also most likely need to jump in to get the custom styles working, so maybe if you could just get it split out on the code side, I can jump in to finish the UI.

As a reminder the designs have been updated and the Figma proto stays the most up to date, so be sure to base work off of that. Here's the latest screenshot.

Screen Shot 2020-09-01 at 12 04 27 PM

@stratoula
Copy link
Contributor

ok @cchaos thank you. I will share a PR with you this week to jump in and do your magic. I will use random icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants