Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Send kibana version as query param to registry #64868

Closed
ruflin opened this issue Apr 30, 2020 · 5 comments
Closed

[EPM] Send kibana version as query param to registry #64868

ruflin opened this issue Apr 30, 2020 · 5 comments
Assignees
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ruflin
Copy link
Member

ruflin commented Apr 30, 2020

The Elastic Package Manager connects to the package registry to receive all the available packages. Inside each package is a definition with which versions of Kibana it is compatible. Then the package registry filters the packages based on the kibana version query param to only show the packages that are compatible with this Kibana version.

Currently Kibana does not send its own version as a query param: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts#L36 This is not a problem at the moment as all the available packages are compatible with the current Kibana version but that might change in the future. Because of this a query param must be introduced.

@ruflin ruflin added Ingest Management:beta1 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin ruflin changed the title [Ingest Management] Send kibana version as query param to registry [Ingest Manager] Send kibana version as query param to registry Apr 30, 2020
@jen-huang jen-huang changed the title [Ingest Manager] Send kibana version as query param to registry [EPM] Send kibana version as query param to registry May 6, 2020
@jen-huang jen-huang added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label May 6, 2020
@jfsiii
Copy link
Contributor

jfsiii commented Jun 2, 2020

Just dropping a note that using a kbn-version header in the request is common in many parts if Kibana and required by some https://github.com/elastic/kibana/search?q=kbn-version&type=Code

Not sure whether to pick one or support both, but there is prior art for this.

@ruflin
Copy link
Member Author

ruflin commented Jun 2, 2020

The /search API endpoint should not depend on headers specific to Kibana. It could also be the website or any consumer querying for packages for a specific Kibana version. Because of this it should be a query param and not a header.

@jfsiii
Copy link
Contributor

jfsiii commented Jun 2, 2020

Works for me

@skh
Copy link
Contributor

skh commented Jul 14, 2020

Implemented in #71443

@skh skh closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants