-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPM] Send kibana version as query param to registry #64868
Comments
Pinging @elastic/ingest-management (Team:Ingest Management) |
Just dropping a note that using a Not sure whether to pick one or support both, but there is prior art for this. |
The /search API endpoint should not depend on headers specific to Kibana. It could also be the website or any consumer querying for packages for a specific Kibana version. Because of this it should be a query param and not a header. |
Works for me |
Implemented in #71443 |
The Elastic Package Manager connects to the package registry to receive all the available packages. Inside each package is a definition with which versions of Kibana it is compatible. Then the package registry filters the packages based on the kibana version query param to only show the packages that are compatible with this Kibana version.
Currently Kibana does not send its own version as a query param: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts#L36 This is not a problem at the moment as all the available packages are compatible with the current Kibana version but that might change in the future. Because of this a query param must be introduced.
The text was updated successfully, but these errors were encountered: