Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] disabling any within the code #64145

Closed
gmmorris opened this issue Apr 22, 2020 · 1 comment · Fixed by #64161
Closed

[Alerting] disabling any within the code #64145

gmmorris opened this issue Apr 22, 2020 · 1 comment · Fixed by #64161
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

Following up from discussion in our weekly sync:

Style guide recommend disabling explicit any within the code.
Disabling any reveals aprox. 400 error caused by changing any to unknown which means we're heavily relying on the lack of type checking - this has also revealed mistakes in unit tests, incorrectly typed uses of ES Query responses and a few smaller potentially mistaken usages of core APIs.

We should disabled the ability to explicit set any wherever possible, fix the mistakes and explicitly add an ignore where it is unavoidable.

This will include the following modules that represent around 200 uses of any:

  1. alerting
  2. alerting_builtin
  3. actions
  4. task manager
  5. event log

Triggers UI causes aprox. 200 errors on its own so that will be handled in a subsequent PR.

@gmmorris gmmorris added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Apr 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris removed v7.8.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 22, 2020
@gmmorris gmmorris self-assigned this Apr 22, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants