Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expressions: functions for core apis & shared services #61769

Closed
9 of 10 tasks
ppisljar opened this issue Mar 30, 2020 · 2 comments
Closed
9 of 10 tasks

expressions: functions for core apis & shared services #61769

ppisljar opened this issue Mar 30, 2020 · 2 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta

Comments

@ppisljar
Copy link
Member

ppisljar commented Mar 30, 2020

usage of core apis & shared services in expressions should be limited, as any function using them is no longer pure and with many api's like accessing saved objects it has other problems like reference extraction.

we should provide basic functions for:

for each of these items we need to:

  • register a new function to the expression service
  • return its own expression type so that other functions using these services in arguments can enforce that the service is accessed via the appropriate function
  • add a toExpressionAst method or similar utility that can convert an instance to its AST representation using the new function, or in some cases adding utilities for serializing/deserializing the instances

related: #59960

@ppisljar ppisljar added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Mar 30, 2020
20 tasks
@lukeelmers lukeelmers changed the title expressions: functions for core apis expressions: functions for core apis & shared services Jun 1, 2020
@lukeelmers lukeelmers added the Meta label Jun 1, 2020
@lukeelmers lukeelmers self-assigned this Jun 8, 2020
@lukeelmers lukeelmers removed their assignment Dec 7, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Apr 20, 2021
@ppisljar
Copy link
Member Author

closing this as the majority of work has been completed and we have separate issues to track remaining work

@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label Apr 26, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:medium Medium Level of Effort labels Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta
Projects
None yet
Development

No branches or pull requests

3 participants