-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram bar hover only works once #5930
Comments
Am I missing something in this video? |
@rashidkpc The hover color (lighter green) only shows for the first hover. After that the bars remain the normal green on hover. Looks like the |
Looks like the issue is here, with the Dispatch.prototype.highlightLegend = function (element) {
var label = this.getAttribute('data-label');
if (!label) return;
$('[data-label]', element.parentNode).not('[data-label="' + label + '"]').css('opacity', 0.5);
};
/**
* Mouseout Behavior
*
* @param element {D3.Selection}
* @method unHighlightLegend
*/
Dispatch.prototype.unHighlightLegend = function (element) {
$('[data-label]', element.parentNode).css('opacity', 1);
}; The hover for the histogram behaves differently than for the |
Submitted a PR for this. Let me know if I'm missing anything. |
fixed by #9044 when hovering over a bar chart (histogram, or over any other vislib chart for that matter) it will highlight bars with the same label. the bug was actually the first bar being highlighted ...it should not be as all bars are count. This was fixed to match vislib behaviour in the other charts |
edit: Normally hovering over a bar causes the bar to fade out a little but. This seems to only work for the first bar each time a visualization is rendered. After re-rendering it will again work one time.
The text was updated successfully, but these errors were encountered: