Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Consolidate AST Types #45816

Closed
crob611 opened this issue Sep 16, 2019 · 2 comments
Closed

[Canvas] Consolidate AST Types #45816

crob611 opened this issue Sep 16, 2019 · 2 comments
Assignees
@crob611
Labels
chore Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@crob611
Copy link
Contributor

crob611 commented Sep 16, 2019

PR #36437 adds an appropriate type to the fromExpression function on the interpreter.

We use the AST type from the data plugin in several places, but should switch to use that new type.
@crob611 crob611 self-assigned this Sep 16, 2019
@kobelb kobelb added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@nickpeihl nickpeihl added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 23, 2023
@ThomThomson
Copy link
Contributor

Closing this for the time being as we currently are not prioritizing Canvas tech debt tasks.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crob611 crob611

Labels
chore Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@crob611 @kobelb @timroes @timductive @nickpeihl @ThomThomson @elasticmachine