Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating to apps when welcome screen is present #39689

Closed
liza-mae opened this issue Jun 26, 2019 · 11 comments · Fixed by #58371
Closed

Navigating to apps when welcome screen is present #39689

liza-mae opened this issue Jun 26, 2019 · 11 comments · Fixed by #58371
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test high Team:Operations Team label for Operations Team test_infra test_xpack_functional test test-cloud

Comments

@liza-mae
Copy link
Contributor

We have some cloud tests that are failing due to the welcome screen about 27 tests, although this setting is disabled in on-prem testing we don't have this option in cloud. It would be nice if our navigating methods in FTR could check for it and click to continue.

@liza-mae liza-mae added test Team:Operations Team label for Operations Team test_infra test_xpack_functional failed-test A test failure on a tracked branch, potentially flaky-test test-cloud labels Jun 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage

@kobelb
Copy link
Contributor

kobelb commented Jul 11, 2019

Is it possible to add kibana.disableWelcomeScreen to https://github.com/elastic/cloud/blob/master/scala-services/adminconsole/src/main/scala/no/found/adminconsole/clusters/kibana/validation/KibanaUserSettingsValidator.scala so we can configure this in Cloud and not have to change all these tests?

@liza-mae
Copy link
Contributor Author

Currently there is not -- I have a case open on that end too -- but after speaking with Spencer we thought it would be good to also have this, I will follow up.

@jinmu03
Copy link
Contributor

jinmu03 commented Oct 2, 2019

@liza-mae any update on the welcome screen?

@liza-mae
Copy link
Contributor Author

liza-mae commented Oct 2, 2019

@jinmu03 I think I have a solution, it is currently in testing :) I will assign this issue to me.

@liza-mae liza-mae self-assigned this Oct 2, 2019
@liza-mae
Copy link
Contributor Author

Fixed via elastic/elastic-stack-testing#390

@liza-mae
Copy link
Contributor Author

Reopening for another test need, @pheyos is going to look at adding this functionality to FTR.

@liza-mae liza-mae reopened this Jan 24, 2020
@liza-mae liza-mae removed their assignment Jan 24, 2020
@liza-mae
Copy link
Contributor Author

The fix I put in only works on staging, but Robert wants to run these tests on production, I think bypassing the welcome screen will at least allow those tests to run and I agree there is value in running these tests on production too. One staging/production difference I found in #51522 and also possibly #55632 .

@flash1293
Copy link
Contributor

The home app will show the welcome screen when there are no registered index patterns and the local storage key home:welcome:show does not contain "false". Both options seem like viable alternatives to setting disableWelcomeScreen in kibana.yml. For example I was able to run the index pattern feature control tests skipped here #39389

by adding

      await browser.setLocalStorageItem('home:welcome:show', 'false');

after line 32 in https://github.com/elastic/kibana/blob/7.6/x-pack/test/functional/page_objects/security_page.js#L32.

This will make sure it is set after Kibana is loaded but before the welcome screen is already visible.
Adding a fake index pattern instead of using empty_kibana would also be possible, but would probably require a few changes in the tests itself.

@liza-mae What do you think? Would this be a good solution to you?

@liza-mae
Copy link
Contributor Author

@flash1293 nice! Yes this sounds like a good solution to me, let's give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test high Team:Operations Team label for Operations Team test_infra test_xpack_functional test test-cloud
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants