Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Add ability to validate recursive ICU messages #25226

Closed
LeanidShutau opened this issue Nov 6, 2018 · 3 comments
Closed

[Tools] Add ability to validate recursive ICU messages #25226

LeanidShutau opened this issue Nov 6, 2018 · 3 comments
Assignees
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@LeanidShutau
Copy link
Contributor

LeanidShutau commented Nov 6, 2018

We need to parse nested ICU messages, example:

intl.formatMessage(
  {
    id: 'xpack.beatsManagement.beats.removedNotificationDescription',
    defaultMessage:
      'Removed tag {tag} from {assignmentsLength, plural, one {beat {beatName}} other {# beats}}.',
  },
  {
    tag: 'tagValue',
    assignmentsLength: 'assignmentsLengthValue',
    beatName: 'beatNameValue',
  }
);

Currently beatName reference is ignored.

ICU messages parser in i18n_check tool should parse ICU messages recursively.

@LeanidShutau LeanidShutau added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Nov 6, 2018
@LeanidShutau LeanidShutau self-assigned this Nov 6, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@azasypkin
Copy link
Member

azasypkin commented Nov 7, 2018

@LeanidShutau can you please add more details to the issue description? I suspect it's something related to what we've been discussing recently but can't match title to anything I am aware of.

@LeanidShutau
Copy link
Contributor Author

@LeanidShutau can you please add more details to the issue description? I suspect it's something related to what we've been discussing recently but can't match title to anything I am aware of.

Of course. TODO means that I'm planning to update the description. I just didn't have time to do that, but also didn't want to forget about the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants