Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSVB browser crash when using missing field on annotation row template #25046

Closed
markov00 opened this issue Nov 2, 2018 · 1 comment
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markov00
Copy link
Member

markov00 commented Nov 2, 2018

Kibana version:
6.3, 6.4, 7.0

Steps to reproduce:

  1. Create a TSVB visualization with a simple timeseries
  2. Add one annotation, specify all the required paramenters, but specify on the Row Template a wrong field like value: {{unexistent_field}}
  3. Now hover over an annotation and kibana will crash with the following screen:

screen shot 2018-11-02 at 12 07 15

Expected behavior:
two possibilities:

  • when entering a row template, validate if before showing the tooltips
  • or enable writing wrong templates but avoid the error displaying a warning message on the tooltip

Screenshots (if relevant):

Errors in browser console (if relevant):
Error on kibana 7.0(master)

Uncaught Invariant Violation: Objects are not valid as a React child (found: object with keys {description, fileName, lineNumber, message, name, number, error}). If you meant to render a collection of children, use an array instead. in div (created by Annotation) in div (created by Annotation) in div (created by Annotation) in div (created by Annotation) in div (created by Annotation) in Annotation (created by TimeseriesChart) in div (created by TimeseriesChart) in TimeseriesChart (created by Timeseries) in div (created by Timeseries) in div (created by Timeseries) in div (created by Timeseries) in Timeseries (created by TimeseriesVisualization) in div (created by TimeseriesVisualization) in TimeseriesVisualization (created by Visualization) in Visualization (created by VisEditor) in VisEditor (http://localhost:5601/uow/bundles/vendors.bundle.js:13091)
Version: 7.0.0-alpha1
Build: 9007199254740991
Error: Uncaught Invariant Violation: Objects are not valid as a React child (found: object with keys {description, fileName, lineNumber, message, name, number, error}). If you meant to render a collection of children, use an array instead.
    in div (created by Annotation)
    in div (created by Annotation)
    in div (created by Annotation)
    in div (created by Annotation)
    in div (created by Annotation)
    in Annotation (created by TimeseriesChart)
    in div (created by TimeseriesChart)
    in TimeseriesChart (created by Timeseries)
    in div (created by Timeseries)
    in div (created by Timeseries)
    in div (created by Timeseries)
    in Timeseries (created by TimeseriesVisualization)
    in div (created by TimeseriesVisualization)
    in TimeseriesVisualization (created by Visualization)
    in Visualization (created by VisEditor)
    in VisEditor (http://localhost:5601/uow/bundles/vendors.bundle.js:13091)
    at window.onerror (http://localhost:5601/uow/bundles/commons.bundle.js:212733:32)
    at Object.invokeGuardedCallbackDev (http://localhost:5601/uow/bundles/vendors.bundle.js:203131:16)
    at invokeGuardedCallback (http://localhost:5601/uow/bundles/vendors.bundle.js:203180:29)
    at replayUnitOfWork (http://localhost:5601/uow/bundles/vendors.bundle.js:214291:7)
    at renderRoot (http://localhost:5601/uow/bundles/vendors.bundle.js:214858:11)
    at performWorkOnRoot (http://localhost:5601/uow/bundles/vendors.bundle.js:215411:24)
    at performWork (http://localhost:5601/uow/bundles/vendors.bundle.js:215332:9)
    at performSyncWork (http://localhost:5601/uow/bundles/vendors.bundle.js:215309:5)
    at batchedUpdates (http://localhost:5601/uow/bundles/vendors.bundle.js:215503:9)
    at batchedUpdates (http://localhost:5601/uow/bundles/vendors.bundle.js:204932:12)
    at dispatchEvent (http://localhost:5601/uow/bundles/vendors.bundle.js:207268:5)

Error in kibana 6.3

Fatal Error
Uncaught Invariant Violation: Minified React error #31; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7Bdescription%2C%20fileName%2C%20lineNumber%2C%20message%2C%20name%2C%20number%2C%20error%7D&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings. (http://localhost:5663/bundles/vendors.bundle.js:141)
Version: 6.3.0
Build: 17230
Error: Uncaught Invariant Violation: Minified React error #31; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7Bdescription%2C%20fileName%2C%20lineNumber%2C%20message%2C%20name%2C%20number%2C%20error%7D&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings. (http://localhost:5663/bundles/vendors.bundle.js:141)
    at window.onerror (http://localhost:5663/bundles/commons.bundle.js:3:778114)

Error in kibana 6.4

Fatal Error
Uncaught Invariant Violation: Minified React error #31; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7Bdescription%2C%20fileName%2C%20lineNumber%2C%20message%2C%20name%2C%20number%2C%20error%7D&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings. (http://localhost:5664/bundles/vendors.bundle.js:213)
Version: 6.4.0
Build: 17929
Error: Uncaught Invariant Violation: Minified React error #31; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=31&args[]=object%20with%20keys%20%7Bdescription%2C%20fileName%2C%20lineNumber%2C%20message%2C%20name%2C%20number%2C%20error%7D&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings. (http://localhost:5664/bundles/vendors.bundle.js:213)
    at window.onerror (http://localhost:5664/bundles/commons.bundle.js:3:768238)
@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 2, 2018
@alexwizp
Copy link
Contributor

Will be fixed here: #19385 (Pull Request: #27780)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants