Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename aria-label to generate search report instead of Search Report #19477

Closed
bhavyarm opened this issue May 28, 2018 · 3 comments
Closed

Rename aria-label to generate search report instead of Search Report #19477

bhavyarm opened this issue May 28, 2018 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG AA

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 6.3.0 BC6

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Aria-label for reporting on discover should be renamed to generate search report instead of search report. So screenreaders can accurately announce that clicking that button will facilitate generation of search reports.

aria_label

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience :Sharing Project:Accessibility (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels May 28, 2018
@stacey-gammon
Copy link
Contributor

If we are being very literal, clicking on that top button won't actually generate the report, it will only open the reporting panel. So maybe it's more accurate the way it is now? The actual button has the Generate prefix...

@bhavyarm
Copy link
Contributor Author

@aphelionz what do you think? What Stacey is saying makes sense but for me its not completely accessible. But am fine to close it if you are ok with it. Thanks!

@stacey-gammon
Copy link
Contributor

Discussed and decided it's good as is

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure PR sent :Sharing labels Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Project:Accessibility Team:Visualizations Visualization editors, elastic-charts and infrastructure WCAG AA
Projects
None yet
Development

No branches or pull requests

4 participants