Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.kuiLocalSearchInput has an invalid aria attribute value #19445

Closed
bhavyarm opened this issue May 25, 2018 · 2 comments
Closed

.kuiLocalSearchInput has an invalid aria attribute value #19445

bhavyarm opened this issue May 25, 2018 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 6.3.0 BC6

Elasticsearch version: 6.3.0 BC6

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: The search bar has an invalid aria attribute value(Axe help link)
invalid_aria_attribute

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience :Discovery Project:Accessibility triage_needed labels May 25, 2018
@Bargs
Copy link
Contributor

Bargs commented Jul 3, 2018

@timroes I think you added this attribute, I've got a question. The reason we're seeing this warning is that we moved the documentation link from the query bar to the opt-in popover that comes up when you click "Options" in the query bar. Even if I add the id back to the link, the element won't exist in the page until the user clicks that popover link. Do you know if there's any way to retain the relationship here?

@timroes
Copy link
Contributor

timroes commented Jul 4, 2018

It earlier was described by the "Using Lucene query syntax" label. Since that is gone and I don't think we currently have any other more detailed description on screen, I think you could just remove aria-describedby without any issues. So since the Popover is not in DOM until clicked there is also no way to point towards it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility WCAG A
Projects
None yet
Development

No branches or pull requests

4 participants