Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FontAwesome 3.2.1 to 4.2.0 #1474

Closed
kkirsche opened this issue Sep 4, 2014 · 2 comments
Closed

Update FontAwesome 3.2.1 to 4.2.0 #1474

kkirsche opened this issue Sep 4, 2014 · 2 comments

Comments

@kkirsche
Copy link
Contributor

kkirsche commented Sep 4, 2014

Hi Guys,

I have updated the version of FontAwesome used within Kibana from 3.2.1 to 4.2.0. This will allow for consistent upgrades. The most recent upgrade included a number of icons for graphs such as Line Chart, Pie Chart, etc. which I feel could be useful when asking the user for what type of chart they would like to use.

I would love to know what you think about this.

View Pull Request: #1473

Sorry for the issue after Pull Request. I should have done this before.

Side info:
I have signed the contributor license agreement

@w33ble
Copy link
Contributor

w33ble commented Oct 6, 2014

We're using 4.2.0 in Kibana 4 now, in part because we wanted to use those chart type icons for chart selection.

@w33ble w33ble closed this as completed Oct 6, 2014
@kkirsche
Copy link
Contributor Author

kkirsche commented Oct 6, 2014

No worries. I just saw that. That's the key icons that I saw that were beneficial. You fixed it. Submitting a pull request for a UI bug I found shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants