Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend width shouldn't be hardcoded #13813

Closed
bh9 opened this issue Sep 1, 2017 · 2 comments
Closed

Legend width shouldn't be hardcoded #13813

bh9 opened this issue Sep 1, 2017 · 2 comments
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bh9
Copy link
Contributor

bh9 commented Sep 1, 2017

Describe the feature:
The legend width is hard coded to 150px. This causes problems for entries with long names and is compounded with long lists of entries by the scroll bar. While I appreciate that it should have an upper and lower bound, it shouldn’t be hard coded. It seems the current value was set to lock the width of the colour palette. I would replace width: 150px; (kibana/src/ui/public/vislib/styles/_legend.less line 44) with

min-width: 150px;
max-width: 250px;

Feel free to suggest different values for min and max width if you think these are wrong.

Note, this change will have different results in firefox than all other browsers because of https://bugzilla.mozilla.org/show_bug.cgi?id=1307693 (firefox incorrectly handles overflow-y: auto)

@nreese nreese added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement labels Sep 5, 2017
@thomasneirynck
Copy link
Contributor

I reverted that fix, as it seems to have broken master. #16174.

Likely due to screenshot-tests no longer working. Will revisit.

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@ghudgins
Copy link

this will be addressed in this issue (planned for 8.2 release) #123803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants