Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete courier:batchSearches from settings during 8.0 migration #122662

Closed
Dosant opened this issue Jan 11, 2022 · 1 comment · Fixed by #122672
Closed

Delete courier:batchSearches from settings during 8.0 migration #122662

Dosant opened this issue Jan 11, 2022 · 1 comment · Fixed by #122672
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort TestWeek-8.0 v8.0.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Jan 11, 2022

Kibana version: 8.0-rc1

Description of the problem including expected versus actual behavior:

We removed courier:batchSearches that was deprecated for a while #109350

When upgrading to 8.0 and when you had this setting ON you'd still have it in the advanced settings screen as a custom setting:
Screen Shot 2022-01-11 at 12 24 33

We should remove the setting during 8.0 SO migration:

'8.0.0': (doc: SavedObjectUnsanitizedDoc<any>): SavedObjectSanitizedDoc<any> => ({
...doc,
...(doc.attributes && {
attributes: Object.keys(doc.attributes).reduce(
(acc, key) =>
[
// owner: Team:Geo
'visualization:regionmap:showWarnings',
'visualization:tileMap:WMSdefaults',
'visualization:tileMap:maxPrecision',
// owner: Team:Core
'telemetry:optIn',
'xPackMonitoring:allowReport',
'theme:version',
].includes(key)
? {
...acc,
}
: {
...acc,
[key]: doc.attributes[key],
},
{}

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana loe:small Small Level of Effort v8.0.0 Team:AppServicesSv impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. TestWeek-8.0 labels Jan 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort TestWeek-8.0 v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants