Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search] Move integration with execution context to data plugin search service #118230

Closed
lukasolson opened this issue Nov 10, 2021 · 2 comments
Closed

[data.search] Move integration with execution context to data plugin search service #118230

lukasolson opened this issue Nov 10, 2021 · 2 comments
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@lukasolson
Copy link
Member

The execution context service was added in #102039 and implemented for many different visualization types/contexts in #105206. This is part of the work that allows tracing Elasticsearch queries to their origin.

The current flow for passing execution context looks like this:

  1. Embeddable creates execution context & passes to expressions service
  2. Expression service passes it to search source/search service
  3. Search service passes it to bsearch route
  4. Bsearch route passes it to execution context service

This is not ideal because other plugins using the server-side search service will not have any way of integrating with the execution context service. Instead, the bsearch route should pass all options through to the server-side data plugin search service, which would be responsible for calling the execution context service itself.
@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Team:AppServicesSv labels Nov 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 19, 2021
@lukasolson lukasolson added Team:AppServicesSv and removed needs-team Issues missing a team label labels Nov 19, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Nov 22, 2021
@lukasolson
Copy link
Member Author

I don't believe this is necessary following the merge of #124996.

@exalate-issue-sync exalate-issue-sync bot reopened this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukasolson @elasticmachine