Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade assistant shows duplicate plugin names for fetch_error deprecation level #113330

Closed
jportner opened this issue Sep 28, 2021 · 4 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jportner
Copy link
Contributor

Kibana version: 7.16 (unreleased)

Describe the bug:

If a plugin registers multiple fetch_error level feature deprecations, the callout at the top of the Upgrade Assistantw ill show the plugin name multiple times.

Steps to reproduce:

  1. Start Kibana using this branch: Register kibana_dashboard_only_user and kibana_user roles deprecations in UA. #110960
  2. Add a new role that grants only the manage ES cluster privilege
  3. Add a user that has the new role and the kibana_admin role
  4. Log in with the new user and access the Upgrade Assistant
  5. The security plugin will try to fetch users twice, and it will try to fetch role mappings twice. All four attempts will fail, and the callout at the top will mention the security plugin four times.

Expected behavior: The callout should deduplicate plugin names.

Screenshots (if relevant):

image

@jportner jportner added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Sep 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cjcenizal
Copy link
Contributor

This sounds like a duplicate of #111854, which was fixed by #111888 a couple weeks ago (after the referenced PR was opened). @jportner Could you try bringing that PR up to date with 7.x and verifying this bug still exists?

@jportner
Copy link
Contributor Author

Oh dang, yes that looks to be the case, sorry for the duplicate!

@cjcenizal
Copy link
Contributor

Thanks @jportner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants