Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Support for dropping unsampled transactions (meta) #108466

Closed
3 tasks done
graphaelli opened this issue Aug 12, 2021 · 7 comments
Closed
3 tasks done

[APM] Support for dropping unsampled transactions (meta) #108466

graphaelli opened this issue Aug 12, 2021 · 7 comments
Assignees
Labels
apm:transaction-metrics APM UI - Transaction Metrics Work Team:APM All issues that need APM UI Team support

Comments

@graphaelli
Copy link
Member

graphaelli commented Aug 12, 2021

Meta Issue for tracking overall progress on updates for supporting apm-server.sampling.keep_unsampled: false.

@graphaelli graphaelli added the Team:APM All issues that need APM UI Team support label Aug 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv changed the title [APM] Drop unsampled transactions support (meta) [APM] Support for dropping unsampled transactions (meta) Sep 1, 2021
@dgieselaar dgieselaar self-assigned this Sep 8, 2021
@sorenlouv sorenlouv added the apm:transaction-metrics APM UI - Transaction Metrics Work label Nov 2, 2021
@sorenlouv
Copy link
Member

We are not actively working on making correlations work for metrics, so I suggest we close this and declare metric-power ui released.

@axw
Copy link
Member

axw commented May 18, 2022

IIANM, the transaction latency distribution chart is not using metrics. Is that as intended? Below is what the transaction page looks like after I sent some transactions, waited for metrics to be aggregated, and then deleted traces-apm-default. I expected the latency distribution to be visible, only with no sample traces.

image

@sorenlouv
Copy link
Member

sorenlouv commented May 18, 2022

@axw Thanks for pointing this out. Definitely not intentional. I think we should be able to display the histogram even if correlations doesn't support transaction metrics.

I created a bug report #132394

@dannycroft
Copy link

@sqren @dgieselaar what would like to do with this issue. It's marked as ready but #118437 seems to be marked as stale? Shall we bring it to refinement?

@dgieselaar
Copy link
Member

@dannycroft I think we can close it and keep the other one open. Perhaps we can discuss the ML one in the APM x ML sync?

@sorenlouv
Copy link
Member

sorenlouv commented Jun 9, 2022

Closing this with #132394 as the only immediate follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:transaction-metrics APM UI - Transaction Metrics Work Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

6 participants