Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Event Filter Name should be truncated and a tooltip should be displayed for the same. #102188

Closed
muskangulati-qasource opened this issue Jun 15, 2021 · 11 comments
Assignees
Labels
enhancement New value added to drive a business result NeededFor:Onboarding and Lifecycle Mgt QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.1 v7.16.0

Comments

@muskangulati-qasource
Copy link

In continuation with #101376

Describe the feature:
Event Filter Name should be truncated and a tooltip should be displayed for the same.

Describe a specific use case for the feature:

  • Trusted App Tab:
    TrustedApp

  • Event Filter Tab:
    FilterEvent

@muskangulati-qasource muskangulati-qasource added enhancement New value added to drive a business result Team:Defend Workflows “EDR Workflows” sub-team of Security Solution NeededFor:Onboarding and Lifecycle Mgt v7.14.0 labels Jun 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@manishgupta-qasource
Copy link

Reviewed & Assigned to @kevinlog

@ghost
Copy link

ghost commented Sep 9, 2021

Hi @kevinlog

We tested this ticket on the latest 7.15.0-BC5 environment & found that the issue still exist . Please find below the testing details:

Build Details:

Build Details:
VERSION: 7.15.0-BC5
BUILD: 43957
COMMIT: 0239ff6864dd9930cfe9bcd9a679272f2b7465c2
ARTIFACT: https://staging.elastic.co/7.15.0-edd09abf/summary-7.15.0.html

Screen-Recording:

Administration.-.Kibana.-.Google.Chrome.2021-09-08.18-36-58.mp4

Let me know if you need more information on this.
Thanks!!

@kevinlog kevinlog added v7.15.1 and removed v7.14.0 labels Sep 9, 2021
@kevinlog
Copy link
Contributor

kevinlog commented Sep 9, 2021

@samratbhadra-qasource can you give more details on how you got the cards to look the way they do? Did you put a lot of leading spaces in front of the Event filter name?

@kevinlog
Copy link
Contributor

kevinlog commented Sep 9, 2021

cc @dasansol92 - can you take a look when you get a chance? We can fix this for 7.15.1

@kevinlog kevinlog assigned dasansol92 and unassigned kevinlog Sep 9, 2021
@dasansol92
Copy link
Contributor

@kevinlog Following this comment, I think we decided to let this as it is since the cards in Trusted apps and Event filters are different and are going to be unified with the new artifact card (when adding artifacts by policy). Let me know if this needs to be done before that.

@kevinlog
Copy link
Contributor

kevinlog commented Sep 9, 2021

got it, thanks for the refresher @dasansol92 .

I want to understand how @samratbhadra-qasource produced the look of the cards in the video first, then we can reprioritize or just close this with the intention of introducing Event Filters by Policy soon with the new card.

@ghost
Copy link

ghost commented Sep 9, 2021

Hi @kevinlog No, I haven't entered any leading spaces in front of the Event filter name.

@dasansol92
Copy link
Contributor

dasansol92 commented Sep 9, 2021

Oh, now I see how it looks in the video. So weird... This seems a regression from this commit.
It was fixed (it looked like this) in this pr

@dasansol92
Copy link
Contributor

@kevinlog I think this is old and can be closed as is covered with the new artifacts card design, thoughts?
cc: @muskangulati-qasource

@muskangulati-qasource
Copy link
Author

Hi @kevinlog,

We tested this ticket & found that the issue is Fixed on the 7.16.0-BC5 build. Please find below the testing details:

Build Details:

Kibana version: 7.16.0 BC5
Build: 46061
Commit: f13296db8798dd0cd39ab6cc4a61a35a2a2b05cc
Artifact page: https://staging.elastic.co/7.16.0-4d61fd94/summary-7.16.0.html

Screenshot:
1212

Hence, closing this ticket and marking it as "Validated".

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result NeededFor:Onboarding and Lifecycle Mgt QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.1 v7.16.0
Projects
None yet
Development

No branches or pull requests

5 participants