From e6bbae433bf563eb2fcc4b6b89433d9f06ff454c Mon Sep 17 00:00:00 2001
From: restrry <restrry@gmail.com>
Date: Fri, 31 Jan 2020 14:39:03 +0100
Subject: [PATCH] update tests

---
 .../legacy_object_to_config_adapter.test.ts.snap     |  2 ++
 src/core/server/logging/logging_config.test.ts       | 12 ++++++++++--
 src/core/server/logging/logging_config.ts            |  7 +++++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/src/core/server/legacy/config/__snapshots__/legacy_object_to_config_adapter.test.ts.snap b/src/core/server/legacy/config/__snapshots__/legacy_object_to_config_adapter.test.ts.snap
index 74ecaa9f09c0e1..3b16bed92df976 100644
--- a/src/core/server/legacy/config/__snapshots__/legacy_object_to_config_adapter.test.ts.snap
+++ b/src/core/server/legacy/config/__snapshots__/legacy_object_to_config_adapter.test.ts.snap
@@ -72,6 +72,7 @@ Object {
       },
     },
   },
+  "loggers": undefined,
   "root": Object {
     "level": "off",
   },
@@ -90,6 +91,7 @@ Object {
       },
     },
   },
+  "loggers": undefined,
   "root": Object {
     "level": "all",
   },
diff --git a/src/core/server/logging/logging_config.test.ts b/src/core/server/logging/logging_config.test.ts
index 8eb79ac46e499a..988f96c1cf1049 100644
--- a/src/core/server/logging/logging_config.test.ts
+++ b/src/core/server/logging/logging_config.test.ts
@@ -46,15 +46,23 @@ test('`getLoggerContext()` returns correct joined context name.', () => {
   expect(LoggingConfig.getLoggerContext([])).toEqual('root');
 });
 
-test('correctly fills in default `appenders` config.', () => {
+test('correctly fills in default config.', () => {
   const configValue = new LoggingConfig(config.schema.validate({}));
 
-  expect(configValue.appenders.size).toBe(1);
+  expect(configValue.appenders.size).toBe(3);
 
   expect(configValue.appenders.get('default')).toEqual({
     kind: 'console',
     layout: { kind: 'pattern', highlight: true },
   });
+  expect(configValue.appenders.get('console')).toEqual({
+    kind: 'console',
+    layout: { kind: 'pattern', highlight: true },
+  });
+  expect(configValue.appenders.get('file')).toEqual({
+    kind: 'file',
+    layout: { kind: 'pattern', highlight: false },
+  });
 });
 
 test('correctly fills in custom `appenders` config.', () => {
diff --git a/src/core/server/logging/logging_config.ts b/src/core/server/logging/logging_config.ts
index 5b76e96006a77e..aa87cd6c0c1ffd 100644
--- a/src/core/server/logging/logging_config.ts
+++ b/src/core/server/logging/logging_config.ts
@@ -117,6 +117,13 @@ export class LoggingConfig {
    * Map of the appender unique arbitrary key and its corresponding config.
    */
   public readonly appenders: Map<string, AppenderConfigType> = new Map([
+    [
+      'default',
+      {
+        kind: 'console',
+        layout: { kind: 'pattern', highlight: true },
+      } as AppenderConfigType,
+    ],
     [
       'console',
       {