From 58a1177fab81a9bb522182b35322650a003842ae Mon Sep 17 00:00:00 2001
From: Michail Yasonik <michail.yasonik@elastic.co>
Date: Tue, 29 Jun 2021 16:25:15 -0500
Subject: [PATCH] scroll ML page to fix test

---
 test/functional/services/common/test_subjects.ts           | 7 +++++--
 .../functional/services/ml/data_visualizer_file_based.ts   | 6 +++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/test/functional/services/common/test_subjects.ts b/test/functional/services/common/test_subjects.ts
index ae04fe5d2b9390..2525b6c48bde73 100644
--- a/test/functional/services/common/test_subjects.ts
+++ b/test/functional/services/common/test_subjects.ts
@@ -312,9 +312,12 @@ export class TestSubjects extends FtrService {
     return testSubjSelector(selector);
   }
 
-  public async scrollIntoView(selector: string) {
+  public async scrollIntoView(
+    selector: string,
+    offset: number | { topOffset?: number; bottomOffset?: number }
+  ) {
     const element = await this.find(selector);
-    await element.scrollIntoViewIfNecessary();
+    await element.scrollIntoViewIfNecessary(offset);
   }
 
   // isChecked always returns false when run on an euiSwitch, because they use the aria-checked attribute
diff --git a/x-pack/test/functional/services/ml/data_visualizer_file_based.ts b/x-pack/test/functional/services/ml/data_visualizer_file_based.ts
index 5eece4057ac0c7..291e5a8964553f 100644
--- a/x-pack/test/functional/services/ml/data_visualizer_file_based.ts
+++ b/x-pack/test/functional/services/ml/data_visualizer_file_based.ts
@@ -10,6 +10,8 @@ import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../ftr_provider_context';
 import { MlCommonUI } from './common_ui';
 
+const fixedFooterHeight = 72; // Size of EuiBottomBar more or less
+
 export function MachineLearningDataVisualizerFileBasedProvider(
   { getService, getPageObjects }: FtrProviderContext,
   mlCommonUI: MlCommonUI
@@ -131,7 +133,9 @@ export function MachineLearningDataVisualizerFileBasedProvider(
     },
 
     async selectCreateFilebeatConfig() {
-      await testSubjects.scrollIntoView('fileDataVisFilebeatConfigLink');
+      await testSubjects.scrollIntoView('fileDataVisFilebeatConfigLink', {
+        bottomOffset: fixedFooterHeight,
+      });
       await testSubjects.click('fileDataVisFilebeatConfigLink');
       await testSubjects.existOrFail('fileDataVisFilebeatConfigPanel');
     },