Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDB for Input Packages #5863

Open
ishleenk17 opened this issue Apr 12, 2023 · 4 comments
Open

TSDB for Input Packages #5863

ishleenk17 opened this issue Apr 12, 2023 · 4 comments

Comments

@ishleenk17
Copy link
Contributor

We have been adding TSDB fields to OOTB Integrations where the developer defines all the field mappings beforehand.
Opening up this ticket to curate information/brainstorm on how do we deal with TSDB for Input Packages.

There is no default field mappings in Input Packages.
Are we going to provide the user with the option to add the dimension while doing his custom mappings?
Or is the stand to not support TSDB for Input Packages for now?

cc: @lalit-satapathy @rameshelastic

@lalit-satapathy
Copy link
Collaborator

We will need a way to have input packages (of type metrics), to have metric_types and dimensions annotated; Similar to currently being done for the integration packages. We can take this up, once the initial integration packages are rolled out to the early TSDB customers.

Let's explore, what are the gating changes in the mean time, for us to enable the same.

@lalit-satapathy
Copy link
Collaborator

lalit-satapathy commented May 31, 2023

We had a brief chat among the TSDB team for input package, we would need further discussion. Let me summarise the initial thoughts here:

  • Decide which input packages will have TSDB enabled.

    • This would be simple decision. The input packages are of type metrics, can be chosen to have TSDB enabled.
  • How to enable TSDB for input package

    • Can input packages follow the same principle as integrations and come pre TSDB enabled in the manifest file?
    • Note: input packages do not have any data streams, is enablement like this supported at a package manifest file?
    • Whether the user should have an option to toggle TSDB for input package
      • Initial thoughts: follow same mechanism as integrations. This should not be an user option.
  • How mappings are provided for the input package?

    • Input packages by definition expects user to provide the mapping. Can we expect Fleet to provide a mechanism for the users to provide these additional mappings in the run time?
    • What is the process to define dimensions for metrics ingested by input packages?
    • What is the process to define metric_types for for input packages?
    • Can we have any package level pre-fined mappings for the above or these are defined runtime?

CC: @ruflin

@ishleenk17
Copy link
Contributor Author

  • Note: input packages do not have any data streams, will enablement like this supported at a package manifest file?

Yes, we will have to add it in the package manifest file

  • What is the process to define dimensions for metrics ingested by input packages?

Currently in the custom mappings I don't see any option to add dimension, metric_types during custom mappings.

  • Can we have any package level pre-fined mappings for the above or these are defined runtime?

There will be some default mapping( for fields which we know are always going to be mapped a certain way). And there will be user mapped fields as well., The way we add dimension for both will vary.

@botelastic
Copy link

botelastic bot commented May 30, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants