Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTablePagination] Update pagination with context menu that announces selected row count #6649

Closed
1Copenut opened this issue Mar 20, 2023 · 3 comments · Fixed by #7186
Closed

Comments

@1Copenut
Copy link
Contributor

I filed an improvement ticket for EuiContextMenu to announce single selected items ( #6648 ). I'd like to update the data grid pagination with this improvement when it's finished.

@cee-chen
Copy link
Member

I don't think this needs to be a separate issue; if we update the underlying EuiContextMenu all pagination components should automatically inherit.

@cee-chen cee-chen changed the title [EuiDataGrid] Update pagination with context menu that announces selected row count [EuiTablePagination] Update pagination with context menu that announces selected row count Aug 28, 2023
@cee-chen
Copy link
Member

After re-reviewing, this should be handled in the EuiTablePagination component rather than in data grid. That way basic and in memory tables also receive this a11y improvement

@1Copenut
Copy link
Contributor Author

1Copenut commented Sep 1, 2023

I started on this update late Friday afternoon. It's remarkably similar to the work I PR'ed in #7153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants