Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBasicTable & EuiInMemoryTable] Props tabs are missing common props #3623

Closed
chandlerprall opened this issue Jun 17, 2020 · 0 comments · Fixed by #4179
Closed

[EuiBasicTable & EuiInMemoryTable] Props tabs are missing common props #3623

chandlerprall opened this issue Jun 17, 2020 · 0 comments · Fixed by #4179
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@chandlerprall
Copy link
Contributor

The Props tabs for both EuiBasicTable and EuiInMemoryTable are missing the data-test-subj and className props. These apply not only to the top level table components, but also some sub-components like the in-memory table's search box, and should be added & described in each relevant location.
@chandlerprall chandlerprall added documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue labels Jun 17, 2020
@cchaos cchaos changed the title BasicTable and InMemoryTable Props tabs are missing props [EuiBasicTable & EuiInMemoryTable] Props tabs are missing common props Sep 20, 2020
@miukimiu miukimiu mentioned this issue Oct 16, 2020
Closed
@miukimiu miukimiu mentioned this issue Oct 26, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs, EuiInMemoryTable] Recreating props tables miukimiu/eui
2 participants
@chandlerprall @cchaos