Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDB: Provide a mechanism for users to go back to old working dashboards. #96169

Closed
lalit-satapathy opened this issue May 16, 2023 · 6 comments
Closed
Labels
:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@lalit-satapathy
Copy link

Summary
If user has an working custom dashboard that gets broken (because it had some wrong aggregation on counters) after enabling TSDB. By disabling TSDB (either by a package upgrade or manual disablement), user should get the dashboard to working state. This gives users an ability to go back to a working state without disrupting the usage.

Current understanding based on offline discussion:
User realises that dashboard isn't loading and then downgrades. Which means another backing index is created (non tsdb). If the visualization/dashboard loads and the tsdb backing index is included in the query then an error can still occur (i think shard level error).

TBD
@lalit-satapathy to create a testing scenario for this.

CC: @martijnvg @ruflin

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label May 16, 2023
@lalit-satapathy lalit-satapathy added the :StorageEngine/TSDB You know, for Metrics label May 16, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 16, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 16, 2023
@lalit-satapathy
Copy link
Author

duplicate of #96170

@ruflin
Copy link
Member

ruflin commented May 16, 2023

The expected behaviour here would be that the query still works, but for the time span where TSDB was enabled, the visualisation would be empty. @lalit-satapathy Is this accurate?

@lalit-satapathy
Copy link
Author

The expected behaviour here would be that the query still works, but for the time span where TSDB was enabled, the visualisation would be empty. @lalit-satapathy Is this accurate?

Planning to verify the issue once in a real testcase.

@mlunadia
Copy link

The expected behaviour here would be that the query still works, but for the time span where TSDB was enabled, the visualisation would be empty. @lalit-satapathy Is this accurate?

@ruflin On conversation with the TSDB team last week they confirmed that any time range including a portion of data from a TSDB index would not work and Kibana has no automatic mechanism to exclude the TSDB index from the query.
If a user faced issues and decided to disable TSDB, any broken dashboards would only work for time ranges pre-TSDB and post-TSDB.
There were some suggestions of manually handling the data to fix the issue it but seemed like it implied a lot of manual work.

@martijnvg
Copy link
Member

Let's move this conversation to #96170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

5 participants