Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a configurable title of the legend #862

Closed
timroes opened this issue Oct 8, 2020 · 5 comments · Fixed by #1889
Closed

Allow a configurable title of the legend #862

timroes opened this issue Oct 8, 2020 · 5 comments · Fixed by #1889
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue

Comments

@timroes
Copy link

timroes commented Oct 8, 2020

To make timelion in Kibana use elastic-charts we'd need to be able to have the "header"/"title" of the legend be configurable. This currently shows the active hovered time when you hover over the chart. We'd need this either built into elastic-chart, or make the title configurable, so we can build this implementation on the Kibana side:

screenshot-20201008-100941

Kibana cross issue: elastic/kibana#79984

@timroes timroes added enhancement New feature or request :legend Legend related issue labels Oct 8, 2020
@timroes timroes added the kibana cross issue Has a Kibana issue counterpart label Oct 8, 2020
@markov00
Copy link
Member

markov00 commented Jan 21, 2021

I've taken a deeper look at Timelion and I think we can live without that feature for the following reasons:

  • when moving the mouse over the chart, Timelion doesn't show the tooltip, but the legend act as a tooltip: the header is the current cursor position along the x-axis + every series current value. Our tooltip works exactly in the same way at the moment.
  • keep consistency with other tools using elastic-charts: I think it's preferable to use the same tooltip all over the place, instead of having Timelion charts with a Legend-Tooltip but Lens one having Legend + Tooltip
  • in a near future, the tooltip and the legend can be designed as a unique and interchangeable component, and at that point, we can have a fixed legend/tooltip like today in Timelion. I prefer to work on this together with all the legend and tooltip redesign effort Legends #580 Tooltip redesign #615

@timroes are you ok if we change the way Timelion legend/tooltip works and align that to the available behavior of elastic-charts? The need to render the legend within the chart will remain and we will work on that
I don't think this is considered a breaking change because our tooltip provides exactly the same information provided by the Timelion legend

@markov00
Copy link
Member

@stratoula could you please check if you are ok with my previous comment?

@stratoula
Copy link

stratoula commented Apr 13, 2021

@markov00 as this information appears on hover and works exactly as our tooltip I am fine with that and I agree, let's be consistent

@markov00
Copy link
Member

Ok good, I'm closing this ticket as we are not going to implement the requested feature.
If required, please feel free to reopen it

@yannbolliger
Copy link
Contributor

Would be awesome to have customisable legend titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants