Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations to the legend #555

Closed
1 of 3 tasks
Tracked by #2321
markov00 opened this issue Feb 18, 2020 · 3 comments
Closed
1 of 3 tasks
Tracked by #2321

Add annotations to the legend #555

markov00 opened this issue Feb 18, 2020 · 3 comments
Labels
enhancement New feature or request :legend Legend related issue

Comments

@markov00
Copy link
Member

markov00 commented Feb 18, 2020

Is your feature request related to a problem? Please describe.
Actually, the legend shows only the series names. We should also add the ability to include any annotation to the legend with it's own marker/colors/icons

Screenshot 2020-02-18 at 16 25 27

Screenshot 2020-03-27 at 15 33 22

Describe the solution you'd like
We should have a prop in the Annotation component that describe if we want that annotation displayed on the legend or not. (By default, to avoid breaking changes, that option should be off).
The legend should display the name/id of the annotation + one of the following:

  • the marker/icon if the LineAnnotation has a marker configured
  • a small vertical/horizontal line if the LineAnnotation doesn't have a marker configured, the color should be the same of the annotation stroke
  • a small square with the same fill/opacity of the RectAnnotation
  • Annotation groupings should be toggleable the same as chart series in the legend.

The legend item for each annotation should also allow the user to hide/show the group of annotations.

Describe alternatives you've considered
n/a

Additional context
The requests comes from #522

Kibana Cross Issues

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added enhancement New feature or request :legend Legend related issue labels Feb 18, 2020
@markov00 markov00 mentioned this issue Feb 18, 2020
3 tasks
@markov00 markov00 mentioned this issue Mar 6, 2020
@nickofthyme nickofthyme added this to the Kibana 7.11 milestone Oct 29, 2020
@formgeist
Copy link

@markov00 @nickofthyme Not sure about your prioritization for 7.11, but this is another much-needed addition to the charts in order to display averages across selected time ranges in APM. Can you share an update on this? Thanks 👍

@formgeist
Copy link

I posted this comment in the wrong issue, but would still be valuable to have in the charts for APM as we're displaying multiple different annotations in the charts, and I believe it's not good practice not to show what they each indicate.

@markov00
Copy link
Member Author

markov00 commented May 7, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :legend Legend related issue
Projects
Status: Done
Development

No branches or pull requests

3 participants