-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cloud.* (or cloud related fields) #1725
Comments
The motivation for introducing a common field to store the edge/point of presence (PoP) makes sense. I'm not 100% sure about placing underneath The big three public cloud providers all have CDN services, but not all CDNs will also be cloud providers. A CDN is a type of network, so perhaps I'd be curious about what others think. There's an (inactive) meta issue to assess better how ECS should represent intermediaries like CDNs, proxies, load balancers, etc.: #938. Linking it here since capturing the PoP/edge location might also carry over to that work (and geo-based DNS load balancing use cases). |
I tend to consider CDNs to be a cloud resource which is why my initial thought was to put it there and its not only CDNs that have "edge locations" (Like the Route 53 resolveres), but under network could work too. I'm tracking #938 and the conversation for when I built the Cloudflare Integration for the agent. With that logic, you could also put it under |
@ebeahan Can we use this issue to discuss other fields to possible add to the
|
Feel free to expand the discussion, but please update the title to reflect the new scope. Opening an RFC might be best if we're discussing adding several fields. The proposal template and different stages can help anchor the conversation and provide a place for example mappings, concerns, etc. |
Do What about placing the VPC name/id values under |
They could be at the root. My thought was only that the image is a instance specific thing. kinda follows suite with
I thought about I was also thinking something similar for S3/Object store |
Bringing this back up. Any thoughts on the above. I can start drafting up an RFC. Any other cloud(ish) fields? |
There's been past discussion about a |
One thing i'm missing in the cloud fields is the original id of a resource, any resource. /cc @ebeahan |
stage 0 RFC merged so i'm going to close this and start working on the stage 1 PR |
Summary
Add a
cloud.edge_location
or something similar field.Motivation:
Many cloud providers have not just regions but edge locations, many of which use Airport codes to identify them. This includes providers like cloudflare and AWS (used with route53, CloudFront...). It would nice to have a standard cloud.* field to put this information in.
Detailed Design:
Provide additional details around the design of the proposed changes.
Field:
cloud.edge_location
Example: IAD (https://www.cloudflarestatus.com for a list of cloudflare edge locations and their codes)
Type: keyword
Samples:
AWS CloudFront
AWS Route 53
Cloudflare
The text was updated successfully, but these errors were encountered: