Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebase github action #3000

Closed
Callisto13 opened this issue Dec 30, 2020 · 4 comments · Fixed by #3127
Closed

Add rebase github action #3000

Callisto13 opened this issue Dec 30, 2020 · 4 comments · Fixed by #3127

Comments

@Callisto13
Copy link
Contributor

I really dislike the Update branch button on PRs. It leaves us with a really messy commit history.

Apparently this is a common complaint: isaacs/github#88 and isaacs/github#1113 (comment)

Also the Update branch is not accessible to the person who owns the PR.. not that I really want anyone clicking it.

What do we think about adding https://github.com/cirrus-actions/rebase? We could configure it so that the core team + the PR owner can add a /rebase comment to a PR and boom: lovely commit history.

@Callisto13
Copy link
Contributor Author

wdyt @weaveworks/eksctl-reviewers ?

@aclevername
Copy link
Contributor

I don't have any strong preferences either way 😄

@michaelbeaumont
Copy link
Contributor

I'm fine with it but I think we should be squash + merging PRs anyway so I don't think this should affect the history very much either way

@Callisto13
Copy link
Contributor Author

🤔 alright let's talk about enforcing that as a policy. I am concerned that it will lead to large commits which make debugging/bisecting harder in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants