Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unnecessary code for multi-arch images #2538

Closed
martina-if opened this issue Aug 13, 2020 · 1 comment · Fixed by #2947
Closed

Delete unnecessary code for multi-arch images #2538

martina-if opened this issue Aug 13, 2020 · 1 comment · Fixed by #2947
Assignees
@Callisto13
Labels
priority/important-soon Ideally to be resolved in time for the next release

Comments

@martina-if
Copy link
Contributor

When launching support for ARM we added code that made sure that after creating a cluster the default addons where updated to the newest version with the multi-arch images (their label has the suffix -eksbuild.1).

Once the multi-architecture images are used by EKS by default when creating clusters, that code can be removed from eksctl.

The code is marked with a // TODO. Check the ARM PR for more details.
@martina-if martina-if mentioned this issue Aug 13, 2020
Merged
6 tasks
@martina-if martina-if added the priority/important-soon Ideally to be resolved in time for the next release label Sep 15, 2020
@Callisto13 Callisto13 self-assigned this Dec 10, 2020
@Callisto13 Callisto13 mentioned this issue Dec 15, 2020
Merged
5 tasks
@Callisto13
Copy link
Contributor

Thanks @martina-if for making this so straightforward ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Callisto13 Callisto13

Labels
priority/important-soon Ideally to be resolved in time for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete UpdateAddonsTask Callisto13/eksctl
2 participants
@martina-if @Callisto13