-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Mapped superclass #27
Conversation
<?php | ||
|
||
/* | ||
* This file is part of the FOSUserBundle package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this header file should be the EkinoWordpressBundle
header file because "please view the LICENSE file that was distributed with this source code" is regarding this bundle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the code comes from FOSUserBundle so I was thinking it was nice to keep track of original authorship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, we can keep it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header need to be the one from this project. However the copyright holder can be kept in the class comment. // cc @dbu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file is definitely not part of FOSUserBundle when its added in this bundle :-) according to MIT license you are free to copy it and add the header for this bundle.
i don't mind about the @author
thing, do as you please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the header must be the EkinoWordpressBundle
one but I think this is normal to keep your @author
tag, thank you for that clarification.
I think this is a great to allow extending models. However, can you explain me why there are 2 Doctrine configuration files? (for entities and for models): Thank you! |
¡ola! To be honest, excluding repositories override, I don't have a clue yet why it should be overridden but I didn't want to restrict developers' ability to extend anything |
Alright @xavismeh, so let's keep it like that. Can you just add some little lines in the Thank you :) |
Can you add test for RegisterMappingsPass ? thanks |
* register mappings compiler pass yet. | ||
* | ||
* @deprecated Compatibility class to make the bundle work with Symfony < 2.3. | ||
* To be removed when this bundle drops support for Symfony < 2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, do you still support symfony < 2.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good remark : it should be compliant with 2.1+ but not tested (yet). Will add this environment cases in travis
@xavismeh you need to rebase this PR |
Conflicts: .gitignore DependencyInjection/EkinoWordpressExtension.php
Thank you @xavismeh |
Refactored classes to allow usage out of the box or ease ability to override classes used