Update sneaky_create to update internal rails 5 structure correctly #19

g0ody · 2018-07-23T13:40:26Z

In rails 5 id_in_database is introduced and some validation checks are build upon this new attribute (e.g.: uniqueness).

houndci-bot · 2018-07-23T13:40:37Z

lib/sneaky-save.rb

+    copy_internal(data, self, "@new_record")
+    copy_internal(data, self, "@destroyed")
+
+    !!self.id


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2018-07-23T13:40:37Z

lib/sneaky-save.rb

+    dynamic_keys = sneaky_attributes_without_id.keys.map { |key| ":#{key.name}" }.join(', ')
+    mapping = sneaky_attributes_without_id.map { |key, value| [jey.name.to_sym, value]}.to_h
+    table = self.class.table_name
+    sql = "INSERT INTO #{table} (#{column_keys}) VALUES (#{dynamic_keys}) RETURNING *"


Metrics/LineLength: Line is too long. [86/80]

houndci-bot · 2018-07-23T13:40:38Z

lib/sneaky-save.rb

+    sneaky_attributes_without_id = self.sneaky_attributes_values.except { |key| key.name == 'id' }
+    column_keys = sneaky_attributes_without_id.keys.map(&:name)
+    dynamic_keys = sneaky_attributes_without_id.keys.map { |key| ":#{key.name}" }.join(', ')
+    mapping = sneaky_attributes_without_id.map { |key, value| [jey.name.to_sym, value]}.to_h


Lint/UnusedBlockArgument: Unused block argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used.
Metrics/LineLength: Line is too long. [92/80]
Layout/SpaceInsideBlockBraces: Space missing inside }.

houndci-bot · 2018-07-23T13:40:38Z

lib/sneaky-save.rb

-    !!(self.id ||= new_id)
+    sneaky_attributes_without_id = self.sneaky_attributes_values.except { |key| key.name == 'id' }
+    column_keys = sneaky_attributes_without_id.keys.map(&:name)
+    dynamic_keys = sneaky_attributes_without_id.keys.map { |key| ":#{key.name}" }.join(', ')


Metrics/LineLength: Line is too long. [92/80]
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-23T13:40:38Z

lib/sneaky-save.rb

-
-    @new_record = false
-    !!(self.id ||= new_id)
+    sneaky_attributes_without_id = self.sneaky_attributes_values.except { |key| key.name == 'id' }


Style/RedundantSelf: Redundant self detected.
Metrics/LineLength: Line is too long. [98/80]
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-23T13:48:07Z

lib/sneaky-save.rb

-    if id.nil? && !prefetch_pk_allowed
-      attributes_values.reject! { |key, _| key.name == 'id' }
-    end
+    sql  = <<~SQL


Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceAroundOperators: Operator = should be surrounded by a single space.

houndci-bot · 2018-07-23T13:48:08Z

lib/sneaky-save.rb

-    attributes_values = sneaky_attributes_values
+    mapping = sneaky_attributes_without_id
+      .map { |key, value| [key.name.to_sym, value]}
+      .to_h


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .to_h with sneaky_attributes_without_id on line 47.

houndci-bot · 2018-07-23T13:48:08Z

lib/sneaky-save.rb


-    attributes_values = sneaky_attributes_values
+    mapping = sneaky_attributes_without_id
+      .map { |key, value| [key.name.to_sym, value]}


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with sneaky_attributes_without_id on line 47.
Layout/SpaceInsideBlockBraces: Space missing inside }.

houndci-bot · 2018-07-23T13:48:08Z

lib/sneaky-save.rb

+    column_keys = sneaky_attributes_without_id.keys.map(&:name)
+    dynamic_keys = sneaky_attributes_without_id.keys
+      .map { |key| ":#{key.name}" }
+      .join(', ')


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .join with .keys on line 43.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-23T13:48:08Z

lib/sneaky-save.rb

-    end
+    column_keys = sneaky_attributes_without_id.keys.map(&:name)
+    dynamic_keys = sneaky_attributes_without_id.keys
+      .map { |key| ":#{key.name}" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 43.

houndci-bot · 2018-07-23T13:48:08Z

lib/sneaky-save.rb

@@ -36,28 +36,33 @@ def sneaky_create_or_update
  # Performs INSERT query without running any callbacks
  # @return [false, true]
  def sneaky_create
-    prefetch_pk_allowed = sneaky_connection.prefetch_primary_key?(self.class.table_name)
+    sneaky_attributes_without_id = sneaky_attributes_values
+      .except { |key| key.name == 'id' }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .except with sneaky_attributes_values on line 39.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-23T14:47:07Z

lib/sneaky-save.rb

+      if definition.able_to_type_cast?
+       [definition.name.to_sym, definition.type_cast_for_database(value)]
+      else
+       [definition.name.to_sym, value]


Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-07-23T14:47:08Z

lib/sneaky-save.rb

+
+    mapping = sneaky_attributes_without_id.map do |definition, value|
+      if definition.able_to_type_cast?
+       [definition.name.to_sym, definition.type_cast_for_database(value)]


Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-07-23T14:47:08Z

lib/sneaky-save.rb

-    if id.nil? && prefetch_pk_allowed
-      self.id = sneaky_connection.next_sequence_value(self.class.sequence_name)
+    sneaky_attributes_without_id = sneaky_attributes_values
+                                   .except { |key| key.name == "id" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-07-23T15:17:21Z

lib/sneaky-save.rb

+          if result.respond_to?(:encoder)
+            [definition.name.to_sym, result.encoder.encode(value)]
+          else
+            raise RuntimeError.new('Unknown Type Casted Struct')


Style/RedundantException: Redundant RuntimeError.new call can be replaced with just the message.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-25T11:30:29Z

lib/sneaky-save.rb

+                   .join(", ")
+
+    constraint = if avoid_insert_conflict.present?
+                   "ON CONFLICT (#{[avoid_insert_conflict].flatten.join(', ')}) "\


Metrics/LineLength: Line is too long. [82/80]

houndci-bot · 2018-07-25T11:30:29Z

lib/sneaky-save.rb

+    column_keys = sneaky_attributes_without_id.keys.map(&:name).join(", ")
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }
+                   .join(", ")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .join with .keys on line 43.

houndci-bot · 2018-07-25T11:30:29Z

lib/sneaky-save.rb

+
+    column_keys = sneaky_attributes_without_id.keys.map(&:name).join(", ")
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 43.

houndci-bot · 2018-07-25T11:30:29Z

lib/sneaky-save.rb

-    !!(self.id ||= new_id)
+  def sneaky_create(avoid_insert_conflict: nil)
+    sneaky_attributes_without_id = sneaky_attributes_values
+                                   .except { |key| key.name == "id" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

houndci-bot · 2018-07-25T11:30:29Z

lib/sneaky-save.rb

-  def sneaky_create_or_update
-    new_record? ? sneaky_create : sneaky_update
+  def sneaky_create_or_update(avoid_insert_conflict: nil)
+    new_record? ? sneaky_create(avoid_insert_conflict: avoid_insert_conflict) : sneaky_update


Metrics/LineLength: Line is too long. [93/80]

houndci-bot · 2018-07-31T16:10:45Z

lib/sneaky-save.rb

+                  .join(", ")
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }
+                   .join(", ")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .join with .keys on line 45.

houndci-bot · 2018-07-31T16:10:45Z

lib/sneaky-save.rb

+                  .map { |key| "\"#{key}\"" } # to avoid conflicts with column names
+                  .join(", ")
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 45.

houndci-bot · 2018-07-31T16:10:45Z

lib/sneaky-save.rb

+
+    column_keys = sneaky_attributes_without_id.keys
+                  .map { |key| "\"#{key}\"" } # to avoid conflicts with column names
+                  .join(", ")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .join with .keys on line 42.

houndci-bot · 2018-07-31T16:10:45Z

lib/sneaky-save.rb

+                                   .except { |key| key.name == "id" }
+
+    column_keys = sneaky_attributes_without_id.keys
+                  .map { |key| "\"#{key}\"" } # to avoid conflicts with column names


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 42.
Metrics/LineLength: Line is too long. [84/80]

houndci-bot · 2018-07-31T16:14:16Z

lib/sneaky-save.rb

+
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }
+                   .join(", ")


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .join with .keys on line 46.

houndci-bot · 2018-07-31T16:14:16Z

lib/sneaky-save.rb

+                  .join(", ")
+
+    dynamic_keys = sneaky_attributes_without_id.keys
+                   .map { |key| ":#{key.name}" }


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 46.

houndci-bot · 2018-07-31T16:14:17Z

lib/sneaky-save.rb

+                                   .except { |key| key.name == "id" }
+
+    column_keys = sneaky_attributes_without_id.keys
+                  .map { |key| "\"#{key.name}\"" } # to avoid conflicts with column names


Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Layout/MultilineMethodCallIndentation: Align .map with .keys on line 42.
Metrics/LineLength: Line is too long. [89/80]

houndci-bot · 2018-08-01T14:48:06Z

lib/sneaky-save.rb

+    target.instance_variable_set(key, source.instance_variable_get(key))
+  end
+
+  def generate_constraint(avoid_insert_conflict, column_keys, column_keys)


Lint/Syntax: duplicate argument name

einzige · 2018-08-24T11:29:51Z

There is another problem with arel_attributes_with_values_for_create

houndci-bot · 2019-07-15T10:32:35Z

lib/sneaky-save.rb

+    # by manipulating ranges so that they are not seen as iterable and will be properly handled by
+    # ActiveRecord::Sanitization.quote_bound_value
+    # https://github.com/rails/rails/issues/36682
+    value.instance_eval('undef :map') if value.is_a?(Range)


Style/EvalWithLocation: Pass FILE and LINE to eval method, as they are used by backtraces.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-07-15T10:32:35Z

lib/sneaky-save.rb

    end
  end

+  def quote(value)
+    # The built-in Sanitization of Rails does not handle time ranges very well. We work around this
+    # by manipulating ranges so that they are not seen as iterable and will be properly handled by


Metrics/LineLength: Line is too long. [98/80]

houndci-bot · 2019-07-15T10:32:36Z

lib/sneaky-save.rb

    end
  end

+  def quote(value)
+    # The built-in Sanitization of Rails does not handle time ranges very well. We work around this


Metrics/LineLength: Line is too long. [99/80]

houndci-bot · 2019-07-15T10:32:36Z

lib/sneaky-save.rb

-      send :arel_attributes_values
+    attributes_with_values = send :attributes_with_values_for_create, attribute_names
+    attributes_with_values.each_with_object({}) do |attribute_value, hash|
+      hash[self.class.send(:arel_attribute, attribute_value[0])] = attribute_value[1]


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2019-07-15T10:32:36Z

lib/sneaky-save.rb

-      send :arel_attributes_with_values_for_create, attribute_names
-    else
-      send :arel_attributes_values
+    attributes_with_values = send :attributes_with_values_for_create, attribute_names


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2019-07-15T10:32:36Z

lib/sneaky-save.rb

+          if result.respond_to?(:encoder)
+            [definition.name.to_sym, quote(result.encoder.encode(value))]
+          else
+            raise RuntimeError.new('Unknown Type Casted Struct')


Style/RedundantException: Redundant RuntimeError.new call can be replaced with just the message.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Rails 6 compatibility

Rails 7

houndci-bot reviewed Jul 23, 2018

View reviewed changes

g0ody force-pushed the master branch from 1770733 to 475406d Compare July 23, 2018 13:47

houndci-bot reviewed Jul 23, 2018

View reviewed changes

g0ody force-pushed the master branch 3 times, most recently from 3b08060 to 08d34fd Compare July 23, 2018 14:46

houndci-bot reviewed Jul 23, 2018

View reviewed changes

Update sneaky_create to update internal rails 5 structure correctly

ec5a15a

g0ody force-pushed the master branch from 08d34fd to ec5a15a Compare July 23, 2018 15:17

houndci-bot reviewed Jul 23, 2018

View reviewed changes

Add upsert option to sneaky_save

88562b2

houndci-bot reviewed Jul 25, 2018

View reviewed changes

fixup! Add upsert option to sneaky_save

329ade4

houndci-bot reviewed Jul 31, 2018

View reviewed changes

fixup! Add upsert option to sneaky_save

82dcabe

houndci-bot reviewed Jul 31, 2018

View reviewed changes

Add support for partial index upserts

a31bcf8

houndci-bot reviewed Aug 1, 2018

View reviewed changes

g0ody added 4 commits August 1, 2018 16:55

fixup! Add support for partial index upserts

27b2f85

fixup! Add support for partial index upserts

0e57da5

fixup! Add upsert option to sneaky_save

613ad7e

fixup! Add upsert option to sneaky_save

0ec61fc

Rails 5.2 compatibility

c63d4ec

houndci-bot reviewed Jul 15, 2019

View reviewed changes

Tolsto and others added 3 commits November 26, 2019 19:39

Rails 6 compatibility

d2b517f

Merge pull request #1 from Tolsto/master

eb52200

Rails 6 compatibility

Fix arel_attribute deprecation

230d993

g0ody force-pushed the master branch from a3fbeb1 to 230d993 Compare February 16, 2021 12:50

Add workaround for Ruby 3

5a878f6

Tolsto and others added 2 commits March 8, 2023 03:59

Rails 7 fix

62d3554

Merge pull request #2 from platogo/rails7

8d1235b

Rails 7

Update sneaky_create to update internal rails 5 structure correctly #19

Are you sure you want to change the base?

Update sneaky_create to update internal rails 5 structure correctly #19

Conversation

g0ody commented Jul 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

einzige commented Aug 24, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment