Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer import isomorphic-git #224

Closed
knownasilya opened this issue Jun 19, 2019 · 2 comments
Closed

Can no longer import isomorphic-git #224

knownasilya opened this issue Jun 19, 2019 · 2 comments

Comments

@knownasilya
Copy link
Contributor

ERROR in ./node_modules/globalyzer/src/index.js
Module not found: Error: Can't resolve 'path' in '/Users/ilya/sandbox/branch/node_modules/globalyzer/src'
 @ ./node_modules/globalyzer/src/index.js 1:13-28
 @ ./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js
 @ /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/app.js
 @ multi /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/l.js /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/app.jsBuild Error (Bundler)

webpack returned errors to ember-auto-import


Stack Trace and Error Report: /var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/error.dump.f8c0d592d763e6f58e768429a46559fb.log
@ef4
Copy link
Collaborator

ef4 commented Jun 19, 2019

path is a node-only, built-in package.

We had a bug where we were accidentally providing automatic polyfills for that and several other node built-in packages, but we fixed the bug. And unfortunately due to the "only one copy must win" nature of ember-auto-import, there's not much way to gracefully roll out this bugfix (apps and addons can all update independently and all of them must be prepared to deal with the new version taking over). Sorry it bit you. See also previous #218 (comment)

You can affirmatively add the polyfill like:

autoImport: {
  webpack: { 
    node: { 
      path: true 
    }
}

@knownasilya
Copy link
Contributor Author

Ah, I was hoping this was the issue. Thanks

jacobq added a commit to EmberMN/ember-cli-plotly that referenced this issue Oct 2, 2019
This fixes a test failure that began appearing after upgrading
ember-auto-import, which stopped automatically enabling webpack
polyfills in v1.4.0. See the URLs below for more details:
https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed
embroider-build/ember-auto-import#224 (comment)
https://webpack.js.org/configuration/node/

This commit also drops `ember-cli-htmlbars-inline-precompile` since
it is now deprecated and no longer needed.
jacobq added a commit to EmberMN/ember-cli-plotly that referenced this issue Oct 2, 2019
* chore: ember-cli-update --to 3.13.1

Also mass-upgrade dependencies

* fix: re-enable node polyfills in ember-auto-import

This fixes a test failure that began appearing after upgrading
ember-auto-import, which stopped automatically enabling webpack
polyfills in v1.4.0. See the URLs below for more details:
https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed
embroider-build/ember-auto-import#224 (comment)
https://webpack.js.org/configuration/node/

This commit also drops `ember-cli-htmlbars-inline-precompile` since
it is now deprecated and no longer needed.

* ci: test on node 8

* ci: increase memory limit to 2GiB

This is to work around what appears to be a problem with
babel/ember-cli-babel/... on node 8 / 10.
awesome341 added a commit to awesome341/Ember.js-Plotly.js that referenced this issue Feb 13, 2020
* chore: ember-cli-update --to 3.13.1

Also mass-upgrade dependencies

* fix: re-enable node polyfills in ember-auto-import

This fixes a test failure that began appearing after upgrading
ember-auto-import, which stopped automatically enabling webpack
polyfills in v1.4.0. See the URLs below for more details:
https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed
embroider-build/ember-auto-import#224 (comment)
https://webpack.js.org/configuration/node/

This commit also drops `ember-cli-htmlbars-inline-precompile` since
it is now deprecated and no longer needed.

* ci: test on node 8

* ci: increase memory limit to 2GiB

This is to work around what appears to be a problem with
babel/ember-cli-babel/... on node 8 / 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants