Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to migrate from :loader? #52

Closed
aspiers opened this issue Feb 26, 2018 · 6 comments
Closed

how to migrate from :loader? #52

aspiers opened this issue Feb 26, 2018 · 6 comments

Comments

@aspiers
Copy link
Collaborator

aspiers commented Feb 26, 2018

I just upgraded my req-package installation, and all the uses of :loader are now broken. I see that this is mentioned in the changelog entry for 1.1 but please could you document how to deal with breaking changes like this? Thanks!

@edvorg
Copy link
Collaborator

edvorg commented Feb 26, 2018

Hello. Sorry for breaking your config. Unfortunately, it's not a custom in emacs community to fix your extensions on single version in order to avoid such surprises. Please, refer to use-package documentation on ensure system and all related stuff. Basically el-get loader should be replaced with :el-get keyword provided by use-package-el-get extension, path loader should be replaced with use-package load-path functionality and elpa with :ensure keyword from ensure system. Custom user defined loaders are no longer supported. If you used that, I suggest to implement a tiny package that adds new keyword to use package. It's very easy and takes just two functions to implement. (Check use-package-el-get as reference implementation).

@edvorg
Copy link
Collaborator

edvorg commented Feb 26, 2018

I'd like to concentrate functionality of this package on dependency management only and don't make it another do-it-all package management system for emacs. use-package already has everything user might ever need and only lacks dependency management, which can not be implemented as a keyword extension.

edvorg added a commit that referenced this issue Feb 26, 2018
add migration instructions link as requested in #52
@aspiers
Copy link
Collaborator Author

aspiers commented Feb 28, 2018

Hey, thanks a lot for the helpful reply and for improving the README! Yeah I know the emacs community is currently not a place conducive to best practices around things like SemVer, but I am still crossing my fingers that over time as the package management evolves it will get there. It's already a LOT better in the last few years since rms relinquished a certain amount of control and supporting packages more natively started happening.

I think you are absolutely doing the right thing by shrinking the responsibilities of this package now that use-package natively supports different loaders. It just took me by surprise, but I'm certainly not objecting to it. I don't use custom loaders but I do occasionally use the el-get and load-path loaders. Great to know that use-package supports these! Thanks again :-)

@edvorg
Copy link
Collaborator

edvorg commented Mar 1, 2018

Great to hear that we're on the same page here :) glad that my reply helped

@edvorg
Copy link
Collaborator

edvorg commented Mar 3, 2018

@aspiers do you require any additional assistance on this ticket?

@aspiers
Copy link
Collaborator Author

aspiers commented Mar 3, 2018

No I think I'm good for now - will try out the new approach soon and file a separate issue if I encounter any issues. Thanks a lot again!!

@aspiers aspiers closed this as completed Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants