Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-data):To improve core-data fuzzing test coverage with swagger… #4690

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented Sep 20, 2023

… file update

Closes: #4689

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

run with restler fuzzing test tool:

make docker-fuzz
make fuzz-test-data

the coverage was 20/23 before, but with this PR change, and a manual fix on restler grammar, I'm able to get it to 23/23 coverage.

New Dependency Instructions (If applicable)

@jim-wang-intel
Copy link
Contributor

Testing Instructions

run it with restler fuzzing test tool

what is the expected output, can you add an example to check against it?

bnevis-i
bnevis-i previously approved these changes Sep 21, 2023
@bnevis-i
Copy link
Collaborator

…er file update

Closes: edgexfoundry#4689
Signed-off-by: Valina Li <valina.li@intel.com>
@vli11 vli11 changed the title feat(fuzzing):To improve core-data fuzzing test coverage with swagger… feat(core-data):To improve core-data fuzzing test coverage with swagger… Sep 21, 2023
Signed-off-by: Valina Li <valina.li@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vli11
Copy link
Contributor Author

vli11 commented Sep 21, 2023

Testing Instructions

run it with restler fuzzing test tool

what is the expected output, can you add an example to check against it?

@jim-wang-intel I've updated test instruction and added fuzzing core-data test target.

@vli11
Copy link
Contributor Author

vli11 commented Sep 21, 2023

@vli11 Fuzzing is not a scope. See https://github.com/edgexfoundry/edgex-go/blob/main/.github/semantic.yml#L15

I just amended the PR message. @bnevis-i

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vli11 vli11 merged commit 8da9149 into edgexfoundry:main Sep 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to improve core-data fuzzing test coverage with swagger file update
3 participants